Stop including network_interfaces.h from net_util.h

Stop including network_interfaces.h from net_util.h

network_interfaces.h is splitted off of net_utils.h
( https://codereview.chromium.org/1154323007 ) but leaved to be included in it. Fixed includes in consumers to call both or just one of them.

BUG=488531
Committed: https://crrev.com/80a44bef6973ac271a24285ddb49edf36e7513ca
Cr-Commit-Position: refs/heads/master@{#346591}

[Olli Raula, 2015-08-12 13:37:08]

olli.raula@intel.com changed reviewers:
+ davidben@chromium.org, eroman@chromium.org, miu@chromium.org,
reillyg@chromium.org, sdefresne@chromium.org, sky@chromium.org

[Olli Raula, 2015-08-12 14:33:45]

olli.raula@intel.com changed reviewers:
+ vitalybuka@chromium.org

[Olli Raula, 2015-08-12 15:23:48]

Could you review:

sky: chrome/*
vitalybuka cloud_print/*
sdefresne: components/*
davidben: content/*
reillyg: extensions/*
miu: media/cast/*
eroman: net/*


My name to AUTHORS is coming from here soon, before landing this:
https://codereview.chromium.org/1181413009/

[miu, 2015-08-12 16:52:25]

lgtm

[Reilly Grant (use Gerrit), 2015-08-12 17:45:07]

lgtm

Please update the issue description to describe your changes more accurately. In
all the files I reviewed this patch adds an include, it doesn't remove one.

https://codereview.chromium.org/1290723003/diff/20001/extensions/browser/api/...
File extensions/browser/api/system_network/system_network_api.h (right):

https://codereview.chromium.org/1290723003/diff/20001/extensions/browser/api/...
extensions/browser/api/system_network/system_network_api.h:10: #include
"net/base/net_util.h"
I believe "net/base/net_util.h" is now an unnecessary include.

[eroman, 2015-08-12 18:37:16]

LGTM:

  * Please add "BUG=488531" to the description, and follows reillyg suggested
changes to the description wording.

  * Please add your name to the AUTHORS file as part of this change. I know you
already have done that for https://codereview.chromium.org/1181413009/, however
since this changelist will likely land first it should be in here.

https://codereview.chromium.org/1290723003/diff/20001/net/quic/network_connec...
File net/quic/network_connection.cc (right):

https://codereview.chromium.org/1290723003/diff/20001/net/quic/network_connec...
net/quic/network_connection.cc:7: #include "net/base/net_util.h"
can this be deleted now?

[sky, 2015-08-12 19:16:52]

LGTM

[sdefresne, 2015-08-13 08:07:01]

components/ lgtm

[Olli Raula, 2015-08-13 12:37:35]

Thanks for reviews, still missing two.

I fixed the message more clear version, added AUTHORS fix and removed some
unneeded includes(including those which was suggested).

[davidben, 2015-08-13 15:38:55]

https://codereview.chromium.org/1290723003/diff/60001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/1290723003/diff/60001/AUTHORS#newcode623
AUTHORS:623: Olli Raula (Old name Olli Syrjälä) <olli.raula@intel.com>
[confirmed we have a CLA on file which covers this email address]

Hrm. I do not know what we do in this case.

Elsewhere in the file I see, e.g., Ajay Berwal is listed as both
ajay.berwal@samsung.com and a.berwal@samsung.com, and there are already commits
under olli.syrjara@intel.com in the repository. So I expect that means both
emails should be listed. Maybe:

Olli Raula <olli.raula@intel.com>
Olli Raula (Old name Olli Syrjälä) <olli.syrjala@intel.com>

Then again, there do seem to be other commits that update email addresses, so
perhaps the duplicate lines are an anomaly and this change is correct.

Other Chromium people: how is this file supposed to be maintained?

https://codereview.chromium.org/1290723003/diff/60001/content/renderer/p2p/ip...
File content/renderer/p2p/ipc_network_manager.cc (right):

https://codereview.chromium.org/1290723003/diff/60001/content/renderer/p2p/ip...
content/renderer/p2p/ipc_network_manager.cc:17: #include "net/base/net_util.h"
[confirmed this include is still correct due to
net::IP_ADDRESS_ATTRIBUTE_DEPRECATED]

https://codereview.chromium.org/1290723003/diff/60001/content/renderer/p2p/ip...
File content/renderer/p2p/ipc_network_manager_unittest.cc (right):

https://codereview.chromium.org/1290723003/diff/60001/content/renderer/p2p/ip...
content/renderer/p2p/ipc_network_manager_unittest.cc:9: #include
"net/base/net_util.h"
[confirmed this is still correct due to net::IP_ADDRESS_ATTRIBUTE_NONE]

[Vitaly Buka (NO REVIEWS), 2015-08-19 18:54:48]

lgtm

[Olli Raula, 2015-08-20 10:32:28]

Thanks. I removed the AUTHORS change because my name is already there by
https://codereview.chromium.org/1162603004/ 

davidben can you give your stamp to this.

[davidben, 2015-08-20 15:48:10]

content lgtm

[Olli Raula, 2015-08-21 05:52:33]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-08-21 05:52:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, sky@chromium.org, eroman@chromium.org, miu@chromium.org,
sdefresne@chromium.org, vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1290723003/#ps80001
(title: "TOT and remove AUTHORS change as it is there already")

[commit-bot: I haz the power, 2015-08-21 05:52:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290723003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290723003/80001

[commit-bot: I haz the power, 2015-08-21 06:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 06:02:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Olli Raula, 2015-08-21 06:26:18]

olli.raula@intel.com changed reviewers:
+ tsepez@chromium.org

[Olli Raula, 2015-08-21 06:28:04]

tsepes: could you review: content/common/p2p_messages.h because devidben review
is not enough for that file.

[Tom Sepez, 2015-08-31 17:11:20]

On 2015/08/21 06:28:04, olli.raula wrote:
> tsepes: could you review: content/common/p2p_messages.h because devidben
review
> is not enough for that file.
Messages LGTM.

[Olli Raula, 2015-09-01 05:58:20]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-09-01 05:58:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290723003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290723003/80001

[commit-bot: I haz the power, 2015-09-01 07:41:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-01 07:42:36]

Patchset 5 (id:??) landed as
https://crrev.com/80a44bef6973ac271a24285ddb49edf36e7513ca
Cr-Commit-Position: refs/heads/master@{#346591}