Split network_interfaces.h off of net_utils.h.

Split network_interfaces.h off of net_utils.h.

This includes the network interface enumeration functions, and wifi information that was previously lumped under net_utils.

BUG=488531
NOPRESUBMIT=true

Committed: https://crrev.com/c69886a485a0d1635bece1665a0501138a76b96d
Cr-Commit-Position: refs/heads/master@{#332644}

[eroman, 2015-06-02 23:04:23]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[eroman, 2015-06-02 23:04:24]

I didn't do all the possible cleanups in this initial change to keep edits
manageable.

[mmenke, 2015-06-03 15:12:38]

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces.h:28: #include "net/base/network_change_notifier.h"
By "not doing all the possible cleanups", I assume you mean cleaning up headers?

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces.h:29: #include "net/base/network_interfaces.h"
Shouldn't include itself.  :)

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces_linux.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces_linux.h:15: #include "net/base/net_util.h"
Should include network_interface_linux.h instead of net_util, I believe, though
the cc file may need net_util, not sure.

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces_mac.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces_mac.h:13: #include "net/base/net_util.h"
Should include network_interface_mac.h instead of net_util, I believe, though
the cc file may need net_util, not sure.

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces_win.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces_win.h:16: #include "net/base/net_util.h"
Again, this should presumably be network_interfaces.h

https://codereview.chromium.org/1154323007/diff/40001/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/1154323007/diff/40001/net/net.gypi#newcode265
net/net.gypi:265: 'base/network_interfaces_win.cc',
nit:  Alphabetize

[eroman, 2015-06-03 15:35:53]

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces.h:29: #include "net/base/network_interfaces.h"
On 2015/06/03 15:12:38, mmenke wrote:
> Shouldn't include itself.  :)

ick. fixed

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
File net/base/network_interfaces_linux.h (right):

https://codereview.chromium.org/1154323007/diff/40001/net/base/network_interf...
net/base/network_interfaces_linux.h:15: #include "net/base/net_util.h"
On 2015/06/03 15:12:38, mmenke wrote:
> Should include network_interface_linux.h instead of net_util, I believe,
though
> the cc file may need net_util, not sure.

Done.

this was part of the "not all possible cleanups" because i didn't want to deal
with adding missing per-platform headers yet.

These changes however were simple as nothing outside of net includes
network_interfaces_{platform}.h directly

https://codereview.chromium.org/1154323007/diff/40001/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/1154323007/diff/40001/net/net.gypi#newcode265
net/net.gypi:265: 'base/network_interfaces_win.cc',
On 2015/06/03 15:12:38, mmenke wrote:
> nit:  Alphabetize

Done.

[eroman, 2015-06-03 15:40:09]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 15:41:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154323007/60001

[mmenke, 2015-06-03 15:48:12]

LGTM

[commit-bot: I haz the power, 2015-06-03 18:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 18:10:31]

Dry run: This issue passed the CQ dry run.

[eroman, 2015-06-03 18:14:59]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-06-03 18:16:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154323007/60001

[commit-bot: I haz the power, 2015-06-03 18:20:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-03 18:20:55]

Patchset 4 (id:??) landed as
https://crrev.com/c69886a485a0d1635bece1665a0501138a76b96d
Cr-Commit-Position: refs/heads/master@{#332644}