Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1290633002: Revert of Fix the drift in repeating timers. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix the drift in repeating timers. (patchset #2 id:20001 of https://codereview.chromium.org/1261993006/ ) Reason for revert: this change caused a large amount of flakes, see https://code.google.com/p/chromium/issues/detail?id=517488 and also graphs on http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.linux%20Builder%20linux_chromium_rel_ng%20Success%20Rate%20(Last%20100%20Builds) http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.win%20Builder%20win_chromium_x64_rel_ng%20Success%20Rate%20(Last%20100%20Builds) http://chrome-monitor.appspot.com/view_graph/tryserver.chromium.win%20Builder%20win_chromium_rel_ng%20Success%20Rate%20(Last%20100%20Builds) this was hard to track down because browser_tests weren't printing renderer crashes. i fixed that in an unlanded cl and tried reenabling all the tests and they all had ASSERTION FAILED: now >= m_unalignedNextFireTime see the try runs on this patchset https://codereview.chromium.org/1284083002/#ps20001 i.e. one example: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/92022/steps/browser_tests%20%28with%20patch%29/logs/MSE_ClearKey_Prefixed_EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM_0 BUG=517488 Original issue's description: > Fix the drift in repeating timers. > > Currently repeating blink timers ignore the difference between when the > timer was due to fire and when it actually did. In addition the delay > reported to chromium was rounded up to the nearest millisecond, > introducing unnecessary extra delay. > > (Note seperatly DOMTimers have additional clamping). > > This fairly broken behaviour has been there for a long time, and I > really hope nothing has come to depend on it! > > Judging by > http://www.duckware.com/test/chrome/timeraccuracy.html this patch makes > things a lot better at least on linux. The actual delays are much > closer to the requested ones, and the run time modulo interval shows > the drift is gone. > > BUG=328700 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199903 TBR=jochen@chromium.org,skyostil@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328700 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -104 lines) Patch
M Source/platform/Timer.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M Source/platform/TimerTest.cpp View 26 chunks +34 lines, -94 lines 0 comments Download
M public/platform/WebScheduler.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
Created Revert of Fix the drift in repeating timers.
5 years, 4 months ago (2015-08-12 03:11:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290633002/1
5 years, 4 months ago (2015-08-12 03:11:24 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 03:12:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200375

Powered by Google App Engine
This is Rietveld 408576698