Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290593004: Oilpan: fix build after r200730. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, kinuko+watch, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r200730. TBR=oilpan-reviews BUG=382542 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200733

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DocumentTiming.h View 3 chunks +5 lines, -2 lines 2 comments Download
M Source/core/dom/DocumentTiming.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentLoadTiming.h View 3 chunks +5 lines, -2 lines 1 comment Download
M Source/core/loader/DocumentLoadTiming.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
5 years, 4 months ago (2015-08-18 17:24:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290593004/1
5 years, 4 months ago (2015-08-18 17:24:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200733
5 years, 4 months ago (2015-08-18 17:28:52 UTC) #4
haraken
https://codereview.chromium.org/1290593004/diff/1/Source/core/dom/DocumentTiming.h File Source/core/dom/DocumentTiming.h (right): https://codereview.chromium.org/1290593004/diff/1/Source/core/dom/DocumentTiming.h#newcode66 Source/core/dom/DocumentTiming.h:66: WeakPtrWillBeMember<Document> m_document; I wonder why this needs to be ...
5 years, 4 months ago (2015-08-19 00:00:20 UTC) #6
sof
5 years, 4 months ago (2015-08-19 05:18:46 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1290593004/diff/1/Source/core/dom/DocumentTim...
File Source/core/dom/DocumentTiming.h (right):

https://codereview.chromium.org/1290593004/diff/1/Source/core/dom/DocumentTim...
Source/core/dom/DocumentTiming.h:66: WeakPtrWillBeMember<Document> m_document;
On 2015/08/19 00:00:20, haraken wrote:
> 
> I wonder why this needs to be a WeakPtr in non-oilpan. It looks a bit strange
> that we need weak semantics in non-oilpan but don't need weak semantics in
> oilpan.
> 
> I guess this can be RawPtrWillBeMember.

It is/was a good question, see https://codereview.chromium.org/1290683003/

Powered by Google App Engine
This is Rietveld 408576698