Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1290393002: [serializer] Move WeakFixedArray compaction to separate heap walk phase (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] Move WeakFixedArray compaction to separate heap walk phase This avoids discovering and compacting the same array repeatedly. No change in resulting snapshots intended. R=yangguo@chromium.org Committed: https://crrev.com/c7ba2f7fa35f15d07750a50d6b6cb0cca98275e5 Cr-Commit-Position: refs/heads/master@{#30177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M src/api.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
As discussed. For the Scripts' weak fixed array, it shouldn't matter when we clear them; ...
5 years, 4 months ago (2015-08-14 12:41:33 UTC) #1
Yang
On 2015/08/14 12:41:33, Jakob wrote: > As discussed. > > For the Scripts' weak fixed ...
5 years, 4 months ago (2015-08-14 12:43:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290393002/1
5 years, 4 months ago (2015-08-14 12:43:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 13:09:40 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 13:09:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7ba2f7fa35f15d07750a50d6b6cb0cca98275e5
Cr-Commit-Position: refs/heads/master@{#30177}

Powered by Google App Engine
This is Rietveld 408576698