Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: src/snapshot/serialize.cc

Issue 1290393002: [serializer] Move WeakFixedArray compaction to separate heap walk phase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/serialize.cc
diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc
index 81e071c0fb05809d6b905fe8c5373bbb8e6bc5e6..1e6012f7e75033298631985add97e6c8d10fd3d9 100644
--- a/src/snapshot/serialize.cc
+++ b/src/snapshot/serialize.cc
@@ -1923,38 +1923,10 @@ void Serializer::ObjectSerializer::Serialize() {
// We don't expect fillers.
DCHECK(!object_->IsFiller());
- if (object_->IsPrototypeInfo()) {
- Object* prototype_users = PrototypeInfo::cast(object_)->prototype_users();
- if (prototype_users->IsWeakFixedArray()) {
- WeakFixedArray* array = WeakFixedArray::cast(prototype_users);
- array->Compact<JSObject::PrototypeRegistryCompactionCallback>();
- }
- }
- // Compaction of a prototype users list can require the registered users
- // to update their remembered slots. That doesn't work if those users
- // have already been serialized themselves. So if this object is a
- // registered user, compact its prototype's user list now.
- if (object_->IsMap()) {
- Map* map = Map::cast(object_);
- if (map->is_prototype_map() && map->prototype_info()->IsPrototypeInfo() &&
- PrototypeInfo::cast(map->prototype_info())->registry_slot() !=
- PrototypeInfo::UNREGISTERED) {
- JSObject* proto = JSObject::cast(map->prototype());
- PrototypeInfo* info = PrototypeInfo::cast(proto->map()->prototype_info());
- WeakFixedArray* array = WeakFixedArray::cast(info->prototype_users());
- array->Compact<JSObject::PrototypeRegistryCompactionCallback>();
- }
- }
-
if (object_->IsScript()) {
// Clear cached line ends.
Object* undefined = serializer_->isolate()->heap()->undefined_value();
Script::cast(object_)->set_line_ends(undefined);
- Object* shared_list = Script::cast(object_)->shared_function_infos();
- if (shared_list->IsWeakFixedArray()) {
- WeakFixedArray::cast(shared_list)
- ->Compact<WeakFixedArray::NullCallback>();
- }
}
if (object_->IsExternalString()) {
« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698