net/quic/test_tools/crypto_test_utils_chromium.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/crypto_test_utils_chromium.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Lots of fixes driven by try jobs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/proxy/proxy_service_v8.h ('K') | « net/quic/quic_network_transaction_unittest.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | net/spdy/spdy_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/test_tools/crypto_test_utils_chromium.cc

diff --git a/net/quic/test_tools/crypto_test_utils_chromium.cc b/net/quic/test_tools/crypto_test_utils_chromium.cc

index f1d60f069a9a02ee4c37c89946a136dc2aa0e2c3..6cbbe600812ce263497662be45e6cd1c132dff1e 100644

--- a/net/quic/test_tools/crypto_test_utils_chromium.cc

+++ b/net/quic/test_tools/crypto_test_utils_chromium.cc

@@ -23,11 +23,13 @@ namespace {

class TestProofVerifierChromium : public ProofVerifierChromium {

public:

- TestProofVerifierChromium(CertVerifier* cert_verifier,

+ TestProofVerifierChromium(scoped_ptr<CertVerifier> cert_verifier,

TransportSecurityState* transport_security_state,

pauljensen 2015/08/28 13:38:02 would be nice to make this a scoped_ptr

Randy Smith (Not in Mondays) 2015/09/02 23:42:19 Done.

const std::string& cert_file)

- : ProofVerifierChromium(cert_verifier, nullptr, transport_security_state),

- cert_verifier_(cert_verifier),

+ : ProofVerifierChromium(cert_verifier.get(),

+ nullptr,

+ transport_security_state),

+ cert_verifier_(cert_verifier.Pass()),

transport_security_state_(transport_security_state) {

// Load and install the root for the validated chain.

scoped_refptr<X509Certificate> root_cert =