net/proxy/proxy_service_v8.h - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service_v8.h

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Lots of fixes driven by try jobs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service_v8.h

diff --git a/net/proxy/proxy_service_v8.h b/net/proxy/proxy_service_v8.h

index 0e339ebf3e76bf690e1ee50838de33d948760a6c..f61f633b7a60b77151c62a04936fc1a8cef08526 100644

--- a/net/proxy/proxy_service_v8.h

+++ b/net/proxy/proxy_service_v8.h

@@ -6,6 +6,7 @@

#define NET_PROXY_PROXY_SERVICE_V8_H_

#include "base/basictypes.h"

+#include "base/memory/scoped_ptr.h"

#include "net/base/net_export.h"

namespace net {

@@ -37,7 +38,7 @@ class ProxyService;

// # multi-threading model. In order for this to be safe to use, *ALL* the

// # other V8's running in the process must use v8::Locker.

// ##########################################################################

-NET_EXPORT ProxyService* CreateProxyServiceUsingV8ProxyResolver(

+NET_EXPORT scoped_ptr<ProxyService> CreateProxyServiceUsingV8ProxyResolver(

ProxyConfigService* proxy_config_service,

pauljensen 2015/08/28 13:38:02 would be nice to make this a scoped_ptr

Randy Smith (Not in Mondays) 2015/09/02 23:42:19 See other comment.

ProxyScriptFetcher* proxy_script_fetcher,

DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher,

« net/proxy/proxy_service.h ('K') | « net/proxy/proxy_service_mojo_unittest.cc ('k') | net/proxy/proxy_service_v8.cc » ('j') | net/quic/test_tools/crypto_test_utils_chromium.cc » ('J')