Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1290113003: [Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where. (Closed)

Created:
5 years, 4 months ago by nednguyen
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where. BUG=472672 Committed: https://crrev.com/9d1576e4edddb590bf43df6a08e8fe39e72f0448 Cr-Commit-Position: refs/heads/master@{#343308}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Add chromite LICENSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M tools/telemetry/PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 1 chunk +2 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser_options.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/internal/util/py_trace.py View 1 chunk +0 lines, -11 lines 0 comments Download
A + tools/telemetry/third_party/chromite/LICENSE View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/third_party/chromite/README.chromium View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/chromite/ssh_keys/testing_rsa View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/telemetry/third_party/chromite/ssh_keys/testing_rsa.pub View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
nednguyen
https://codereview.chromium.org/1290113003/diff/40001/tools/telemetry/telemetry/TELEMETRY_DEPS File tools/telemetry/telemetry/TELEMETRY_DEPS (right): https://codereview.chromium.org/1290113003/diff/40001/tools/telemetry/telemetry/TELEMETRY_DEPS#newcode8 tools/telemetry/telemetry/TELEMETRY_DEPS:8: "third_party/android_testrunner/", This is used by pylib.
5 years, 4 months ago (2015-08-13 19:55:19 UTC) #4
nednguyen
5 years, 4 months ago (2015-08-13 19:55:20 UTC) #6
sullivan
lgtm
5 years, 4 months ago (2015-08-13 19:56:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290113003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290113003/60001
5 years, 4 months ago (2015-08-13 19:58:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290113003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290113003/80001
5 years, 4 months ago (2015-08-13 21:40:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 4 months ago (2015-08-14 00:14:29 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9d1576e4edddb590bf43df6a08e8fe39e72f0448 Cr-Commit-Position: refs/heads/master@{#343308}
5 years, 4 months ago (2015-08-14 00:15:34 UTC) #15
binjin
This breaks the Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/6574 [1/1] telemetry.telemetry_dependencies_unittest.TelemetryDependenciesTest.testNoNewTelemetryDependencies failed unexpectedly 10.0118s: Traceback (most recent call ...
5 years, 4 months ago (2015-08-14 08:52:50 UTC) #16
binjin
Created a CL that partially reverts this one, let me know if anything goes wrong. ...
5 years, 4 months ago (2015-08-14 09:54:37 UTC) #17
nednguyen
5 years, 4 months ago (2015-08-14 15:29:41 UTC) #18
Message was sent while issue was closed.
On 2015/08/14 09:54:37, binjin wrote:
> Created a CL that partially reverts this one, let me know if anything goes
> wrong.
> 
> https://codereview.chromium.org/1293743002

+1 to binjin for not reverting the whole thing. I am a bit confused why the cq
bot failed to catch this.

Powered by Google App Engine
This is Rietveld 408576698