tools/telemetry/PRESUBMIT.py - Issue 1290113003: [Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/PRESUBMIT.py

Issue 1290113003: [Telemetry] Remove obsolete dependency. Remove py_trace.py since it's not used any where. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add chromite LICENSE Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | tools/telemetry/bootstrap_deps » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 def _CommonChecks(input_api, output_api):	6 def _CommonChecks(input_api, output_api):

7 results = []	7 results = []

8	8

9 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().	9 # TODO(nduca): This should call update_docs.IsUpdateDocsNeeded().

10 # Disabled due to crbug.com/255326.	10 # Disabled due to crbug.com/255326.

(...skipping 16 matching lines...) Expand all Loading...
27 def _GetPathsToPrepend(input_api):	27 def _GetPathsToPrepend(input_api):

28 telemetry_dir = input_api.PresubmitLocalPath()	28 telemetry_dir = input_api.PresubmitLocalPath()

29 chromium_src_dir = input_api.os_path.join(telemetry_dir, '..', '..')	29 chromium_src_dir = input_api.os_path.join(telemetry_dir, '..', '..')

30 return [	30 return [

31 telemetry_dir,	31 telemetry_dir,

32 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'),	32 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'),

33 input_api.os_path.join(telemetry_dir, 'third_party', 'typ'),	33 input_api.os_path.join(telemetry_dir, 'third_party', 'typ'),

34 input_api.os_path.join(telemetry_dir, 'third_party', 'websocket-client'),	34 input_api.os_path.join(telemetry_dir, 'third_party', 'websocket-client'),

35	35

36 input_api.os_path.join(chromium_src_dir, 'build', 'android'),	36 input_api.os_path.join(chromium_src_dir, 'build', 'android'),

37 input_api.os_path.join(

38 chromium_src_dir, 'third_party', 'py_trace_event', 'src'),

39 input_api.os_path.join(chromium_src_dir, 'third_party', 'catapult'),	37 input_api.os_path.join(chromium_src_dir, 'third_party', 'catapult'),

40 input_api.os_path.join(chromium_src_dir, 'third_party', 'webpagereplay'),	38 input_api.os_path.join(chromium_src_dir, 'third_party', 'webpagereplay'),

41 ]	39 ]

42	40

43	41

44 def CheckChangeOnUpload(input_api, output_api):	42 def CheckChangeOnUpload(input_api, output_api):

45 results = []	43 results = []

46 results.extend(_CommonChecks(input_api, output_api))	44 results.extend(_CommonChecks(input_api, output_api))

47 return results	45 return results

48	46

49	47

50 def CheckChangeOnCommit(input_api, output_api):	48 def CheckChangeOnCommit(input_api, output_api):

51 results = []	49 results = []

52 results.extend(_CommonChecks(input_api, output_api))	50 results.extend(_CommonChecks(input_api, output_api))

53 return results	51 return results

OLD	NEW