Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5318)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 128993004: Fix subtle bug with the in-process utility thread usage in unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
===================================================================
--- chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc (revision 243741)
+++ chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc (working copy)
@@ -27,7 +27,6 @@
#include "components/policy/core/common/policy_types.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
-#include "content/public/browser/render_process_host.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/external_provider_interface.h"
@@ -113,6 +112,8 @@
scoped_refptr<DeviceLocalAccountExternalPolicyLoader> loader_;
MockExternalPolicyProviderVisitor visitor_;
scoped_ptr<extensions::ExternalProviderImpl> provider_;
+
+ content::InProcessUtilityThreadHelper in_process_utility_thread_helper_;
};
DeviceLocalAccountExternalPolicyLoaderTest::
@@ -143,13 +144,10 @@
extensions::Manifest::EXTERNAL_POLICY_DOWNLOAD,
extensions::Extension::NO_FLAGS));
- content::RenderProcessHost::SetRunRendererInProcess(true);
-
VerifyAndResetVisitorCallExpectations();
}
void DeviceLocalAccountExternalPolicyLoaderTest::TearDown() {
- content::RenderProcessHost::SetRunRendererInProcess(false);
TestingBrowserProcess::GetGlobal()->SetSystemRequestContext(NULL);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698