Fix subtle bug with the in-process utility thread usage in unit tests.

chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h"
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
 #include "chrome/browser/extensions/updater/extension_downloader.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "components/policy/core/common/cloud/mock_cloud_policy_store.h"
 #include "components/policy/core/common/policy_map.h"
 #include "components/policy/core/common/policy_types.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
-#include "content/public/browser/render_process_host.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/external_provider_interface.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_test_util.h"
 #include "policy/policy_constants.h"
@@ skipping 65 matching lines @@
   content::TestBrowserThreadBundle thread_bundle_;
   base::ScopedTempDir temp_dir_;
   base::FilePath cache_dir_;
   policy::MockCloudPolicyStore store_;
   scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
   base::FilePath test_dir_;
 
   scoped_refptr<DeviceLocalAccountExternalPolicyLoader> loader_;
   MockExternalPolicyProviderVisitor visitor_;
   scoped_ptr<extensions::ExternalProviderImpl> provider_;
+
+  content::InProcessUtilityThreadHelper in_process_utility_thread_helper_;
 };
 
 DeviceLocalAccountExternalPolicyLoaderTest::
     DeviceLocalAccountExternalPolicyLoaderTest()
     : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {
 }
 
 DeviceLocalAccountExternalPolicyLoaderTest::
     ~DeviceLocalAccountExternalPolicyLoaderTest() {
 }
@@ skipping 10 matching lines @@
 
   loader_ = new DeviceLocalAccountExternalPolicyLoader(&store_, cache_dir_);
   provider_.reset(new extensions::ExternalProviderImpl(
       &visitor_,
       loader_,
       NULL,
       extensions::Manifest::EXTERNAL_POLICY,
       extensions::Manifest::EXTERNAL_POLICY_DOWNLOAD,
       extensions::Extension::NO_FLAGS));
 
-  content::RenderProcessHost::SetRunRendererInProcess(true);
-
   VerifyAndResetVisitorCallExpectations();
 }
 
 void DeviceLocalAccountExternalPolicyLoaderTest::TearDown() {
-  content::RenderProcessHost::SetRunRendererInProcess(false);
   TestingBrowserProcess::GetGlobal()->SetSystemRequestContext(NULL);
 }
 
 void DeviceLocalAccountExternalPolicyLoaderTest::
     VerifyAndResetVisitorCallExpectations() {
   Mock::VerifyAndClearExpectations(&visitor_);
   EXPECT_CALL(visitor_, OnExternalExtensionFileFound(_, _, _, _, _, _))
       .Times(0);
   EXPECT_CALL(visitor_, OnExternalExtensionUpdateUrlFound(_, _, _, _, _))
       .Times(0);
@@ skipping 137 matching lines @@
   loader_->StopCache(shutdown_run_loop.QuitClosure());
   VerifyAndResetVisitorCallExpectations();
 
   // Spin the loop until the cache shutdown callback is invoked. Verify that at
   // that point, no further file I/O tasks are pending.
   shutdown_run_loop.Run();
   EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting());
 }
 
 }  // namespace chromeos