Issue 1289903004: js_global_data and global_alternate violate naming rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1289903004: js_global_data and global_alternate violate naming rules. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

js_global_data and global_alternate violate naming rules. They look too much like locals; use JSGlobalData and JSGlobalAlternate instead. Kill some commented out code. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ed7599b9042169f11b00f1126bfd3aff0f56b35f

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -72 lines)			Patch
M	fpdfsdk/include/javascript/global.h	View	1	5 chunks	+7 lines, -11 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_GlobalData.cpp	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	1	13 chunks	+45 lines, -44 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 4 months ago (2015-08-17 18:58:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ed7599b9042169f11b00f1126bfd3aff0f56b35f (presubmit successful).