Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: fpdfsdk/include/javascript/global.h

Issue 1289903004: js_global_data and global_alternate violate naming rules. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_GlobalData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/global.h
diff --git a/fpdfsdk/include/javascript/global.h b/fpdfsdk/include/javascript/global.h
index 369956749b8e6f341e4d8a2cc09f17712de62d17..e881625f56de645ad9a84c4a14db3f55ae456201 100644
--- a/fpdfsdk/include/javascript/global.h
+++ b/fpdfsdk/include/javascript/global.h
@@ -13,8 +13,8 @@ class CJS_GlobalData;
class CJS_GlobalVariableArray;
class CJS_KeyValue;
-struct js_global_data {
- js_global_data() {
+struct JSGlobalData {
+ JSGlobalData() {
nType = 0;
dData = 0;
bData = FALSE;
@@ -23,7 +23,7 @@ struct js_global_data {
bDeleted = FALSE;
}
- ~js_global_data() { pData.Reset(); }
+ ~JSGlobalData() { pData.Reset(); }
int nType; // 0:int 1:bool 2:string 3:obj
double dData;
bool bData;
@@ -33,18 +33,15 @@ struct js_global_data {
bool bDeleted;
};
-class global_alternate : public CJS_EmbedObj {
+class JSGlobalAlternate : public CJS_EmbedObj {
public:
- global_alternate(CJS_Object* pJSObject);
- ~global_alternate() override;
+ JSGlobalAlternate(CJS_Object* pJSObject);
+ ~JSGlobalAlternate() override;
- public:
FX_BOOL setPersistent(IFXJS_Context* cc,
const CJS_Parameters& params,
CJS_Value& vRet,
CFX_WideString& sError);
-
- public:
FX_BOOL QueryProperty(const FX_WCHAR* propname);
FX_BOOL DoProperty(IFXJS_Context* cc,
const FX_WCHAR* propname,
@@ -53,7 +50,6 @@ class global_alternate : public CJS_EmbedObj {
FX_BOOL DelProperty(IFXJS_Context* cc,
const FX_WCHAR* propname,
CFX_WideString& sError);
-
void Initial(CPDFDoc_Environment* pApp);
private:
@@ -89,7 +85,7 @@ class CJS_Global : public CJS_Object {
DECLARE_SPECIAL_JS_CLASS(CJS_Global);
- JS_SPECIAL_STATIC_METHOD(setPersistent, global_alternate, global);
+ JS_SPECIAL_STATIC_METHOD(setPersistent, JSGlobalAlternate, global);
};
#endif // FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_GlobalData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698