Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289883002: Remove unused content .rc files. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused content .rc files. These were generated and referenced in a few places but seem not to be used. In the GN build such generated .rc files are always compiled and linked, which resulted in duplicate resources. Committed: https://crrev.com/1d64bc0ee6bfaa2455060a14cb5b529aa0a389fd Cr-Commit-Position: refs/heads/master@{#343045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M chromecast/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/app/resources/shell_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/strings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/strings/content_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289883002/1
5 years, 4 months ago (2015-08-12 16:30:06 UTC) #3
brettw
5 years, 4 months ago (2015-08-12 16:30:06 UTC) #4
scottmg
lgtm
5 years, 4 months ago (2015-08-12 16:33:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 17:26:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289883002/1
5 years, 4 months ago (2015-08-12 17:33:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 17:38:55 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 17:40:07 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d64bc0ee6bfaa2455060a14cb5b529aa0a389fd
Cr-Commit-Position: refs/heads/master@{#343045}

Powered by Google App Engine
This is Rietveld 408576698