Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/components_tests.gyp

Issue 1289883002: Remove unused content .rc files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/app/resources/shell_resources.grd ('k') | content/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components_tests.gyp
diff --git a/components/components_tests.gyp b/components/components_tests.gyp
index 37f768568557a9199d60a9e857035565a40126de..352987b3177d058151e1581c02f150b4fd41ffb0 100644
--- a/components/components_tests.gyp
+++ b/components/components_tests.gyp
@@ -1470,11 +1470,6 @@
'sources': [
'../content/shell/app/resource.h',
'../content/shell/app/shell.rc',
- # TODO: It would be nice to have these pulled in automatically
- # from direct_dependent_settings in their various targets, but
- # that causes errors in other targets when resulting .res files
- # get referenced multiple times.
- '<(SHARED_INTERMEDIATE_DIR)/content/app/strings/content_strings_en-US.rc',
],
'dependencies': [
'<(DEPTH)/content/app/resources/content_resources.gyp:content_resources',
« no previous file with comments | « chromecast/app/resources/shell_resources.grd ('k') | content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698