Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: Source/bindings/v8/ExceptionStatePlaceholder.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/PageScriptDebugServer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionStatePlaceholder.h
diff --git a/Source/bindings/v8/ExceptionStatePlaceholder.h b/Source/bindings/v8/ExceptionStatePlaceholder.h
index 84f6eb0b0f621d6a57d64597fa52deb0471e0b3d..f193ba379086391f9261bf114172e664d124a808 100644
--- a/Source/bindings/v8/ExceptionStatePlaceholder.h
+++ b/Source/bindings/v8/ExceptionStatePlaceholder.h
@@ -41,13 +41,13 @@ class ExceptionState;
typedef int ExceptionCode;
-class IgnorableExceptionState : public ExceptionState {
+class IgnorableExceptionState FINAL : public ExceptionState {
public:
IgnorableExceptionState(): ExceptionState(v8::Handle<v8::Object>(), 0) { }
ExceptionState& returnThis() { return *this; }
- virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE FINAL { };
- virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL { }
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE FINAL { }
+ virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE { }
+ virtual void throwTypeError(const String& message = String()) OVERRIDE { }
+ virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE { }
};
#define IGNORE_EXCEPTION (::WebCore::IgnorableExceptionState().returnThis())
@@ -58,13 +58,13 @@ public:
#else
-class NoExceptionStateAssertionChecker : public ExceptionState {
+class NoExceptionStateAssertionChecker FINAL : public ExceptionState {
public:
NoExceptionStateAssertionChecker(const char* file, int line);
ExceptionState& returnThis() { return *this; }
- virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE FINAL;
- virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL;
- virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE FINAL;
+ virtual void throwDOMException(const ExceptionCode&, const String& message = String()) OVERRIDE;
+ virtual void throwTypeError(const String& message = String()) OVERRIDE;
+ virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE;
private:
const char* m_file;
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/PageScriptDebugServer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698