fixes #292, report async_helper test failures

fixes #292, report async_helper test failures

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/d76b79c59feba287e1197fea4d4771e9a6bfcb44

[Jennifer Messerly, 2015-08-19 01:27:57]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-08-19 15:02:36]

lgtm

https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.dart
File test/codegen/async_helper.dart (right):

https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.d...
test/codegen/async_helper.dart:27: Function _onAsyncEnd;
Perhaps give this a signature / typedef to avoid the dcall - nice not to see
them on debugging stack traces.

[Jennifer Messerly, 2015-08-19 15:34:44]

https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.dart
File test/codegen/async_helper.dart (right):

https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.d...
test/codegen/async_helper.dart:27: Function _onAsyncEnd;
On 2015/08/19 15:02:35, vsm wrote:
> Perhaps give this a signature / typedef to avoid the dcall - nice not to see
> them on debugging stack traces.

Done.

fwiw, this method won't really appear on stack traces though. We're just calling
`done` to signal the test is done. Unless there's a bug in Karma/Mocha itself.

also, don't we want to hide those methods in stack traces generally? avoiding
them in our own test code doesn't help end users?

[Jennifer Messerly, 2015-08-19 15:35:39]

Committed patchset #2 (id:20001) manually as
d76b79c59feba287e1197fea4d4771e9a6bfcb44 (presubmit successful).

[vsm, 2015-08-19 15:43:38]

On 2015/08/19 15:34:44, John Messerly wrote:
>
https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.dart
> File test/codegen/async_helper.dart (right):
> 
>
https://codereview.chromium.org/1289673007/diff/1/test/codegen/async_helper.d...
> test/codegen/async_helper.dart:27: Function _onAsyncEnd;
> On 2015/08/19 15:02:35, vsm wrote:
> > Perhaps give this a signature / typedef to avoid the dcall - nice not to see
> > them on debugging stack traces.
> 
> Done.
> 
> fwiw, this method won't really appear on stack traces though. We're just
calling
> `done` to signal the test is done. Unless there's a bug in Karma/Mocha itself.
> 
> also, don't we want to hide those methods in stack traces generally? avoiding
> them in our own test code doesn't help end users?

Good point, opened #297 to start documenting this sort of stuff.