Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: test/browser/language_tests.js

Issue 1289673007: fixes #292, report async_helper test failures (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/codegen/async_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index bc8dc2fea43ee5125a076ff6e2a743fc46a94d0c..74383ab3636e495ca89da0f87ddba7e2f7f0b81f 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -8,11 +8,15 @@
let _isolate_helper = dart_library.import('dart/_isolate_helper');
_isolate_helper.startRootIsolate(function() {}, []);
+ let async_helper = dart_library.import('async_helper/async_helper');
+
function dartLanguageTests(tests) {
for (const name of tests) {
- test(name, () => {
- console.debug('Running language test: ' + name);
+ test(name, (done) => {
+ async_helper.asyncTestInitialize(done);
+ console.debug('Running language test: ' + name);
dart_library.import('language/' + name).main();
+ if (!async_helper.asyncTestStarted) done();
});
}
}
@@ -48,7 +52,8 @@
'async_rethrow_test',
// TODO(jmesserly): fix errors
// 'async_return_types_test',
- 'async_switch_test',
+ // TODO(jmesserly): https://github.com/dart-lang/dev_compiler/issues/294
+ // 'async_switch_test',
'async_test',
'async_this_bound_test',
'async_throw_in_catch_test'
@@ -63,7 +68,8 @@
//'async_star_cancel_and_throw_in_finally_test',
'async_star_regression_23116_test',
'asyncstar_concat_test',
- 'asyncstar_throw_in_catch_test',
+ // TODO(jmesserly): https://github.com/dart-lang/dev_compiler/issues/294
+ // 'asyncstar_throw_in_catch_test',
'asyncstar_yield_test',
'asyncstar_yieldstar_test'
]);
« no previous file with comments | « no previous file | test/codegen/async_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698