Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 16d57284871cec4a6bc3366d10f5fd9b85fc02cd..3a25a96c3157f6a2adf95031eac9111137ca5ebd 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -829,9 +829,17 @@ class RawField : public RawObject {
   RawObject* owner_;  // Class or patch class or mixin class
                       // where this field is defined.
   RawAbstractType* type_;
-  RawInstance* value_;  // Offset in words for instance and value for static.
+  union {

[hausner, 2015/09/01 16:02:02]

Seems a bit over the top to me:

field->value_.static_value_
field->value_.offset_
field->value_.value_

I'm not sure this is more readable than what we have now. Also, only the
accessor functions touch value_, and you already add more specific names to
those.

[siva, 2015/09/03 23:32:10]

My main motivation for doing this was to have a way of documenting what the
overloads are without having to hunt through all the different accessors in
object.h.

I checked this out with a few people and they seemed to be open about this, if
you feel very strongly about this I can leave this alone and only work with the
accessors and maybe think of a better way to document the overloads.

+    RawInstance* static_value_;  // Value for static fields.
+    RawSmi* offset_;  // Offset in words for instance fields.
+    RawObject* value_;  // Used to access the value in a type agnostic way.
+  } value_;
   RawArray* dependent_code_;
-  RawFunction* initializer_;
+  union {
+    RawFunction* precompiled_initializer_;  // Used when precompiling code.
+    RawInstance* saved_initial_value_;  // Saved initial value (static fields).

[hausner, 2015/09/01 16:02:02]

The comment just repeats what the identifier already says. Maybe a longer
comment explaining a bigger picture how/why initializer_ is used would be more
helpful.

[siva, 2015/09/03 23:32:09]

Done.

+    RawObject* value_;  // Used to access the value in a type agnostic way.
+  } initializer_;
   RawSmi* guarded_list_length_;
   RawObject** to() {
     return reinterpret_cast<RawObject**>(&ptr()->guarded_list_length_);