Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/atomic.h"
 #include "vm/globals.h"
@@ skipping 811 matching lines @@
 
 
 class RawField : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(Field);
 
   RawObject** from() { return reinterpret_cast<RawObject**>(&ptr()->name_); }
   RawString* name_;
   RawObject* owner_;  // Class or patch class or mixin class
                       // where this field is defined.
   RawAbstractType* type_;
-  RawInstance* value_;  // Offset in words for instance and value for static.
+  union {

[hausner, 2015/09/01 16:02:02]

Seems a bit over the top to me:

field->value_.static_value_
field->value_.offset_
field->value_.value_

I'm not sure this is more readable than what we have now. Also, only the
accessor functions touch value_, and you already add more specific names to
those.

[siva, 2015/09/03 23:32:10]

My main motivation for doing this was to have a way of documenting what the
overloads are without having to hunt through all the different accessors in
object.h.

I checked this out with a few people and they seemed to be open about this, if
you feel very strongly about this I can leave this alone and only work with the
accessors and maybe think of a better way to document the overloads.

+    RawInstance* static_value_;  // Value for static fields.
+    RawSmi* offset_;  // Offset in words for instance fields.
+    RawObject* value_;  // Used to access the value in a type agnostic way.
+  } value_;
   RawArray* dependent_code_;
-  RawFunction* initializer_;
+  union {
+    RawFunction* precompiled_initializer_;  // Used when precompiling code.
+    RawInstance* saved_initial_value_;  // Saved initial value (static fields).

[hausner, 2015/09/01 16:02:02]

The comment just repeats what the identifier already says. Maybe a longer
comment explaining a bigger picture how/why initializer_ is used would be more
helpful.

[siva, 2015/09/03 23:32:09]

Done.

+    RawObject* value_;  // Used to access the value in a type agnostic way.
+  } initializer_;
   RawSmi* guarded_list_length_;
   RawObject** to() {
     return reinterpret_cast<RawObject**>(&ptr()->guarded_list_length_);
   }
 
   int32_t token_pos_;
   classid_t guarded_cid_;
   classid_t is_nullable_;  // kNullCid if field can contain null value and
                            // any other value otherwise.
   // Offset to the guarded length field inside an instance of class matching
@@ skipping 1360 matching lines @@
   COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
                  kTypedDataInt8ArrayViewCid + 15);
   COMPILE_ASSERT(kByteBufferCid == kExternalTypedDataInt8ArrayCid + 14);
   COMPILE_ASSERT(kNullCid == kByteBufferCid + 1);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_