runtime/vm/flow_graph_type_propagator.cc - Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add-comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index 6af05d6c52e0dc1a37c13f6253b84aa317718455..7ee1a50f3797161db31dcb269cf4d68409907d69 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -996,7 +996,7 @@ CompileType LoadStaticFieldInstr::ComputeType() const {

}

ASSERT(field.is_static());

if (field.is_final()) {

- const Instance& obj = Instance::Handle(field.value());

+ const Instance& obj = Instance::Handle(field.StaticValue());

if ((obj.raw() != Object::sentinel().raw()) &&

(obj.raw() != Object::transition_sentinel().raw()) &&

!obj.IsNull()) {

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »