Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add-comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index 371ec0eb70658f932a35ce667691ce6841942e49..d9188c7e6c3f89ab3c2ef1bd248ff31bc8cbb0e8 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -3804,10 +3804,11 @@ void EffectGraphVisitor::VisitStoreInstanceFieldNode(
void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
if (node->field().is_const()) {
- ASSERT(node->field().value() != Object::sentinel().raw());
- ASSERT(node->field().value() != Object::transition_sentinel().raw());
- Definition* result =
- new(Z) ConstantInstr(Instance::ZoneHandle(Z, node->field().value()));
+ ASSERT(node->field().StaticValue() != Object::sentinel().raw());
+ ASSERT(node->field().StaticValue() !=
+ Object::transition_sentinel().raw());
+ Definition* result = new(Z) ConstantInstr(
+ Instance::ZoneHandle(Z, node->field().StaticValue()));
return ReturnDefinition(result);
}
Value* field_value = Bind(new(Z) ConstantInstr(node->field()));
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698