Issue 128933004: use SkImageInfo directly, instead of converting to SkBitmap::Config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128933004: use SkImageInfo directly, instead of converting to SkBitmap::Config (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
hal.canary, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

use SkImageInfo directly, instead of converting to SkBitmap::Config BUG= R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12972

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -21 lines)			Patch
M	include/core/SkSurface.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/image/SkSurface.cpp	View	2 chunks	+16 lines, -2 lines	0 comments	Download
M	src/image/SkSurface_Base.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/image/SkSurface_Raster.cpp	View	5 chunks	+17 lines, -19 lines	0 comments	Download

Total messages: 5 (0 generated)

scroggo

On 2014/01/08 20:47:35, reed1 wrote: old chunk mismatches :(

6 years, 11 months ago (2014-01-08 20:54:23 UTC) #2

scroggo

On 2014/01/08 20:55:50, reed1 wrote: > 4th try does the trick lgtm

6 years, 11 months ago (2014-01-08 21:14:04 UTC) #4

reed1

6 years, 11 months ago (2014-01-08 21:25:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r12972 (presubmit successful).