Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289213002: Return const by ref instead of const by Value in FetchRequestData::method (Closed)

Created:
5 years, 4 months ago by Paritosh Kumar
Modified:
5 years, 4 months ago
Reviewers:
horo, Paweł Hajdan Jr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return const by ref instead of const by Value in FetchRequestData::method BUG=393155 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/fetch/FetchRequestData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Paritosh Kumar
PTAL.
5 years, 4 months ago (2015-08-14 09:31:29 UTC) #2
horo
lgtm
5 years, 4 months ago (2015-08-14 09:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289213002/1
5 years, 4 months ago (2015-08-14 09:36:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/99081)
5 years, 4 months ago (2015-08-14 09:41:20 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289213002/1
5 years, 4 months ago (2015-08-14 09:50:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/99089)
5 years, 4 months ago (2015-08-14 09:55:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289213002/1
5 years, 4 months ago (2015-08-14 10:27:07 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 11:37:22 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200535

Powered by Google App Engine
This is Rietveld 408576698