Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: Source/modules/fetch/FetchRequestData.h

Issue 1289213002: Return const by ref instead of const by Value in FetchRequestData::method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef FetchRequestData_h 5 #ifndef FetchRequestData_h
6 #define FetchRequestData_h 6 #define FetchRequestData_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "platform/weborigin/KURL.h" 9 #include "platform/weborigin/KURL.h"
10 #include "platform/weborigin/Referrer.h" 10 #include "platform/weborigin/Referrer.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 }; 57 };
58 58
59 static FetchRequestData* create(); 59 static FetchRequestData* create();
60 static FetchRequestData* create(ExecutionContext*, const WebServiceWorkerReq uest&); 60 static FetchRequestData* create(ExecutionContext*, const WebServiceWorkerReq uest&);
61 // Call Request::refreshBody() after calling clone() or pass(). 61 // Call Request::refreshBody() after calling clone() or pass().
62 FetchRequestData* clone(ExecutionContext*); 62 FetchRequestData* clone(ExecutionContext*);
63 FetchRequestData* pass(ExecutionContext*); 63 FetchRequestData* pass(ExecutionContext*);
64 ~FetchRequestData(); 64 ~FetchRequestData();
65 65
66 void setMethod(AtomicString method) { m_method = method; } 66 void setMethod(AtomicString method) { m_method = method; }
67 const AtomicString method() const { return m_method; } 67 const AtomicString& method() const { return m_method; }
68 void setURL(const KURL& url) { m_url = url; } 68 void setURL(const KURL& url) { m_url = url; }
69 const KURL& url() const { return m_url; } 69 const KURL& url() const { return m_url; }
70 bool unsafeRequestFlag() const { return m_unsafeRequestFlag; } 70 bool unsafeRequestFlag() const { return m_unsafeRequestFlag; }
71 void setUnsafeRequestFlag(bool flag) { m_unsafeRequestFlag = flag; } 71 void setUnsafeRequestFlag(bool flag) { m_unsafeRequestFlag = flag; }
72 WebURLRequest::RequestContext context() const { return m_context; } 72 WebURLRequest::RequestContext context() const { return m_context; }
73 void setContext(WebURLRequest::RequestContext context) { m_context = context ; } 73 void setContext(WebURLRequest::RequestContext context) { m_context = context ; }
74 PassRefPtr<SecurityOrigin> origin() { return m_origin; } 74 PassRefPtr<SecurityOrigin> origin() { return m_origin; }
75 void setOrigin(PassRefPtr<SecurityOrigin> origin) { m_origin = origin; } 75 void setOrigin(PassRefPtr<SecurityOrigin> origin) { m_origin = origin; }
76 bool sameOriginDataURLFlag() { return m_sameOriginDataURLFlag; } 76 bool sameOriginDataURLFlag() { return m_sameOriginDataURLFlag; }
77 void setSameOriginDataURLFlag(bool flag) { m_sameOriginDataURLFlag = flag; } 77 void setSameOriginDataURLFlag(bool flag) { m_sameOriginDataURLFlag = flag; }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // FIXME: Support m_manualRedirectFlag; 114 // FIXME: Support m_manualRedirectFlag;
115 // FIXME: Support m_redirectCount; 115 // FIXME: Support m_redirectCount;
116 Tainting m_responseTainting; 116 Tainting m_responseTainting;
117 Member<BodyStreamBuffer> m_buffer; 117 Member<BodyStreamBuffer> m_buffer;
118 String m_mimeType; 118 String m_mimeType;
119 }; 119 };
120 120
121 } // namespace blink 121 } // namespace blink
122 122
123 #endif // FetchRequestData_h 123 #endif // FetchRequestData_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698