Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 12892010: Remove WebMediaPlayerInProcessAndroid (Closed)

Created:
7 years, 9 months ago by qinmin
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove WebMediaPlayerInProcessAndroid The WebmediaPlayerInProcessAndroid is being used for layout tests currently. However, the code path has been largely diverged from that of the WebMediaPlayerImplAndroid. It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser. Instead, we should switch to use content shell for layout tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190221

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -361 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/media/android/webmediaplayer_in_process_android.h View 1 chunk +0 lines, -122 lines 3 comments Download
D webkit/media/android/webmediaplayer_in_process_android.cc View 1 chunk +0 lines, -193 lines 0 comments Download
M webkit/media/webkit_media.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/support/webkit_support.cc View 6 chunks +1 line, -38 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
qinmin
PTAL
7 years, 9 months ago (2013-03-21 18:37:48 UTC) #1
scherkus (not reviewing)
https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h File webkit/media/android/webmediaplayer_in_process_android.h (left): https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h#oldcode59 webkit/media/android/webmediaplayer_in_process_android.h:59: class WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid { can we merge ...
7 years, 9 months ago (2013-03-21 20:07:17 UTC) #2
qinmin
https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h File webkit/media/android/webmediaplayer_in_process_android.h (left): https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h#oldcode59 webkit/media/android/webmediaplayer_in_process_android.h:59: class WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid { Yes, I am ...
7 years, 9 months ago (2013-03-21 20:08:09 UTC) #3
jam
lgtm
7 years, 9 months ago (2013-03-21 20:46:49 UTC) #4
scherkus (not reviewing)
lgtm! https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h File webkit/media/android/webmediaplayer_in_process_android.h (left): https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmediaplayer_in_process_android.h#oldcode59 webkit/media/android/webmediaplayer_in_process_android.h:59: class WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid { On 2013/03/21 ...
7 years, 9 months ago (2013-03-21 20:48:27 UTC) #5
qinmin
+tkent for OWNERs in webkit/support
7 years, 9 months ago (2013-03-21 20:52:46 UTC) #6
tkent
LGTM
7 years, 9 months ago (2013-03-21 20:58:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1
7 years, 9 months ago (2013-03-21 21:03:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1
7 years, 9 months ago (2013-03-22 16:28:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1
7 years, 9 months ago (2013-03-22 19:01:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1
7 years, 9 months ago (2013-03-23 15:45:08 UTC) #11
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 06:56:01 UTC) #12
Message was sent while issue was closed.
Change committed as 190221

Powered by Google App Engine
This is Rietveld 408576698