Remove WebMediaPlayerInProcessAndroid

Remove WebMediaPlayerInProcessAndroid

The WebmediaPlayerInProcessAndroid is being used for layout tests currently.
However, the code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not
reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190221

[qinmin, 2013-03-21 18:37:48]

PTAL

[scherkus (not reviewing), 2013-03-21 20:07:17]

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
File webkit/media/android/webmediaplayer_in_process_android.h (left):

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
webkit/media/android/webmediaplayer_in_process_android.h:59: class
WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid {
can we merge the WebMediaPlayerAndroid base class with
WebMediaPlayerImplAndroid?

[qinmin, 2013-03-21 20:08:09]

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
File webkit/media/android/webmediaplayer_in_process_android.h (left):

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
webkit/media/android/webmediaplayer_in_process_android.h:59: class
WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid {
Yes, I am planning to do that in a seperate CL
On 2013/03/21 20:07:18, scherkus wrote:
> can we merge the WebMediaPlayerAndroid base class with
> WebMediaPlayerImplAndroid?

[jam, 2013-03-21 20:46:49]

lgtm

[scherkus (not reviewing), 2013-03-21 20:48:27]

lgtm!

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
File webkit/media/android/webmediaplayer_in_process_android.h (left):

https://codereview.chromium.org/12892010/diff/1/webkit/media/android/webmedia...
webkit/media/android/webmediaplayer_in_process_android.h:59: class
WebMediaPlayerInProcessAndroid : public WebMediaPlayerAndroid {
On 2013/03/21 20:08:09, qinmin wrote:
> Yes, I am planning to do that in a seperate CL
> On 2013/03/21 20:07:18, scherkus wrote:
> > can we merge the WebMediaPlayerAndroid base class with
> > WebMediaPlayerImplAndroid?
> 

Great!

[qinmin, 2013-03-21 20:52:46]

+tkent for OWNERｓ ｉｎ webkit/support

[tkent, 2013-03-21 20:58:50]

LGTM

[commit-bot: I haz the power, 2013-03-21 21:03:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1

[commit-bot: I haz the power, 2013-03-22 16:28:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1

[commit-bot: I haz the power, 2013-03-22 19:01:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1

[commit-bot: I haz the power, 2013-03-23 15:45:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/12892010/1

[commit-bot: I haz the power, 2013-03-24 06:56:01]

Change committed as 190221