Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py

Issue 1289163002: Improve flakiness logic for print-flaky-tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
diff --git a/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py b/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
index 172e5ba97f248d56456262124c818396792cacc7..1116e0bb220f763816777c2364ea452489f5ce8f 100644
--- a/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
+++ b/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py
@@ -71,11 +71,9 @@ class FlakyTestsTest(CommandsTest):
tool = MockTool()
command.expectations_factory = FakeBotTestExpectationsFactory
options = MockOptions(upload=True)
- expected_stdout = '''
-
-Manually add bug numbers for these and then put the lines in LayoutTests/TestExpectations.
-TODO(ojan): Write a script to file/assign the bugs then create a bot to do this automatically.
-
-'''
+ expected_stdout = flakytests.FlakyTests.OUTPUT % (
+ flakytests.FlakyTests.HEADER,
+ '',
+ flakytests.FlakyTests.FLAKINESS_DASHBOARD_URL % '') + '\n'
self.assert_execute_outputs(command, options=options, tool=tool, expected_stdout=expected_stdout)

Powered by Google App Engine
This is Rietveld 408576698