Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py

Issue 1289163002: Improve flakiness logic for print-flaky-tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import flakytests 5 import flakytests
6 6
7 from webkitpy.common.checkout.scm.scm_mock import MockSCM 7 from webkitpy.common.checkout.scm.scm_mock import MockSCM
8 from webkitpy.layout_tests.layout_package import bot_test_expectations 8 from webkitpy.layout_tests.layout_package import bot_test_expectations
9 from webkitpy.tool.commands.commandtest import CommandsTest 9 from webkitpy.tool.commands.commandtest import CommandsTest
10 from webkitpy.tool.mocktool import MockTool, MockOptions 10 from webkitpy.tool.mocktool import MockTool, MockOptions
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 self.assertEqual(lines[0].specifiers, ['Mac', 'Linux']) 64 self.assertEqual(lines[0].specifiers, ['Mac', 'Linux'])
65 finally: 65 finally:
66 builders._exact_matches = old_builders 66 builders._exact_matches = old_builders
67 67
68 68
69 def test_integration(self): 69 def test_integration(self):
70 command = flakytests.FlakyTests() 70 command = flakytests.FlakyTests()
71 tool = MockTool() 71 tool = MockTool()
72 command.expectations_factory = FakeBotTestExpectationsFactory 72 command.expectations_factory = FakeBotTestExpectationsFactory
73 options = MockOptions(upload=True) 73 options = MockOptions(upload=True)
74 expected_stdout = ''' 74 expected_stdout = flakytests.FlakyTests.OUTPUT % (
75 75 flakytests.FlakyTests.HEADER,
76 Manually add bug numbers for these and then put the lines in LayoutTests/TestExp ectations. 76 '',
77 TODO(ojan): Write a script to file/assign the bugs then create a bot to do this automatically. 77 flakytests.FlakyTests.FLAKINESS_DASHBOARD_URL % '') + '\n'
78
79 '''
80 78
81 self.assert_execute_outputs(command, options=options, tool=tool, expecte d_stdout=expected_stdout) 79 self.assert_execute_outputs(command, options=options, tool=tool, expecte d_stdout=expected_stdout)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698