bookmarks: Remove Profile getter accessor from BookmarkModel.

bookmarks: Remove Profile getter accessor from BookmarkModel.

There are better ways to obtain the pointer to Profile and through BookmarkModel,
isn't the best one. This is a step further in reducing the dependencies on
c/b/profiles/ from c/b/bookmarks.

BUG=144783
R=sky@chromium.org,zea@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191162

[tfarina, 2013-03-26 23:09:03]

Please, take a look.

[tfarina, 2013-03-27 02:13:50]

+Alexei for c/b/ui/cocoa/bookmarks!

I'm looking into how to fix bookmark_bar_folder_controller.mm...

[tfarina, 2013-03-27 03:50:50]

Looks like c/b/ui/cocoa/ is fixed. The question now is whether unit_tests will
pass or not :)

Waiting for the trybot results.

[Alexei Svitkine (slow), 2013-03-27 15:16:39]

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:2473:
profile:browser_->profile()];
Align :'s. If it doesn't fit, add a newline before initWithParentButton: and
indent that 4 more than the previous line.

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:239:
profile:(Profile*)profile {
align the :'s

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:1736:
profile:profile_];
Align the :'s

[sky, 2013-03-27 15:32:53]

bookmark_model.h LGTM. That is the only file I reviewed (I happened on the file
listed below before seeing you had others reviewing it).

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/bookmark_change_processor.h (right):

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/bookmark_change_processor.h:188: Profile* profile_;
Doesn't look like you member initialize this.

[tfarina, 2013-03-27 21:02:27]

waiting for Zea's review of c/b/sync/...

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:2473:
profile:browser_->profile()];
On 2013/03/27 15:16:39, Alexei Svitkine wrote:
> Align :'s. If it doesn't fit, add a newline before initWithParentButton: and
> indent that 4 more than the previous line.

Done.

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:239:
profile:(Profile*)profile {
On 2013/03/27 15:16:39, Alexei Svitkine wrote:
> align the :'s

Done.

https://codereview.chromium.org/12891006/diff/16001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:1736:
profile:profile_];
On 2013/03/27 15:16:39, Alexei Svitkine wrote:
> Align the :'s

Done.

[Alexei Svitkine (slow), 2013-03-27 21:14:38]

cocoa/ lgtm

[Nicolas Zea, 2013-03-28 00:43:07]

sync LGTM

[commit-bot: I haz the power, 2013-03-28 11:14:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12891006/26001

[commit-bot: I haz the power, 2013-03-28 17:26:24]

Change committed as 191162