Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/browser/extensions/display_info_provider_chromeos_unittest.cc

Issue 1289043002: Hookup device dpi for ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/display_info_provider_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
diff --git a/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc b/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
index fa94bc90f9cfdcc72c9d7d4882738189a9b168cd..a1b71ace90be767d5b7563837aef367f2b90f75a 100644
--- a/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
+++ b/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
@@ -165,7 +165,7 @@ TEST_F(DisplayInfoProviderChromeosTest, GetRotation) {
EXPECT_EQ(0, result[0]->rotation);
}
-TEST_F(DisplayInfoProviderChromeosTest, GetHiDPI) {
+TEST_F(DisplayInfoProviderChromeosTest, GetDPI) {
UpdateDisplay("500x600,400x520*2");
DisplayInfo result;
result = DisplayInfoProvider::Get()->GetAllDisplaysInfo();
@@ -178,8 +178,10 @@ TEST_F(DisplayInfoProviderChromeosTest, GetHiDPI) {
EXPECT_EQ("500,0 200x260",
SystemInfoDisplayBoundsToString(result[1]->bounds));
- EXPECT_EQ(2 * 96, result[1]->dpi_x);
- EXPECT_EQ(2 * 96, result[1]->dpi_y);
+ // DPI should be 96 (native dpi) * 200 (display) / 400 (native) when ui scale
+ // is 2.
+ EXPECT_EQ(96 / 2, result[1]->dpi_x);
+ EXPECT_EQ(96 / 2, result[1]->dpi_y);
GetWindowTreeHostManager()->SwapPrimaryDisplay();
@@ -193,8 +195,8 @@ TEST_F(DisplayInfoProviderChromeosTest, GetHiDPI) {
EXPECT_EQ(96, result[0]->dpi_y);
EXPECT_EQ("0,0 200x260", SystemInfoDisplayBoundsToString(result[1]->bounds));
- EXPECT_EQ(2 * 96, result[1]->dpi_x);
- EXPECT_EQ(2 * 96, result[1]->dpi_y);
+ EXPECT_EQ(96 / 2, result[1]->dpi_x);
+ EXPECT_EQ(96 / 2, result[1]->dpi_y);
}
TEST_F(DisplayInfoProviderChromeosTest, GetVisibleArea) {
« no previous file with comments | « chrome/browser/extensions/display_info_provider_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698