Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: chrome/browser/extensions/display_info_provider_chromeos.cc

Issue 1289043002: Hookup device dpi for ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/display/display_info.cc ('k') | chrome/browser/extensions/display_info_provider_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/display_info_provider_chromeos.cc
diff --git a/chrome/browser/extensions/display_info_provider_chromeos.cc b/chrome/browser/extensions/display_info_provider_chromeos.cc
index 68fcecf210bfef38a53adc8609073a413838ea2e..990dac02548309a839f63db28b071330943a199f 100644
--- a/chrome/browser/extensions/display_info_provider_chromeos.cc
+++ b/chrome/browser/extensions/display_info_provider_chromeos.cc
@@ -366,12 +366,13 @@ void DisplayInfoProviderChromeOS::UpdateDisplayUnitInfoForPlatform(
base::Int64ToString(display_manager->mirroring_display_id());
}
- // TODO(hshi): determine the DPI of the screen.
- const float kDpi96 = 96.0;
-
- const float dpi = display.device_scale_factor() * kDpi96;
- unit->dpi_x = dpi;
- unit->dpi_y = dpi;
+ const ash::DisplayInfo& display_info =
+ display_manager->GetDisplayInfo(display.id());
+ const float device_dpi = display_info.device_dpi();
+ unit->dpi_x = device_dpi * display.size().width() /
+ display_info.bounds_in_native().width();
+ unit->dpi_y = device_dpi * display.size().height() /
+ display_info.bounds_in_native().height();
const gfx::Insets overscan_insets =
display_manager->GetOverscanInsets(display.id());
« no previous file with comments | « ash/display/display_info.cc ('k') | chrome/browser/extensions/display_info_provider_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698