Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1288903003: Random clean up of SVGResourcesCache (Closed)

Created:
5 years, 4 months ago by fs
Modified:
5 years, 4 months ago
Reviewers:
davve, pdr., f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Random clean up of SVGResourcesCache * Fix up some comments. * Rename resourcesCacheFromLayoutObject to resourcesCache; let it take a Document& instead (to reflect the wider "scope" it has), and make it return a SVGResourceCache& since the cache will always be present if SVGDocumentExtensions are. * Drop redundant qualification. BUG=521334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200826

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M Source/core/layout/svg/SVGResourcesCache.cpp View 7 chunks +27 lines, -31 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 12 (5 generated)
fs
5 years, 4 months ago (2015-08-19 11:43:52 UTC) #2
davve
Non-owner lgtm. Nice and tidy!
5 years, 4 months ago (2015-08-19 12:25:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288903003/1
5 years, 4 months ago (2015-08-19 13:03:22 UTC) #6
f(malita)
LGTM! https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocumentExtensions.h File Source/core/svg/SVGDocumentExtensions.h (right): https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocumentExtensions.h#newcode63 Source/core/svg/SVGDocumentExtensions.h:63: SVGResourcesCache& resourcesCache() const { return *m_resourcesCache; } Nit: ...
5 years, 4 months ago (2015-08-19 13:04:34 UTC) #7
fs
https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocumentExtensions.h File Source/core/svg/SVGDocumentExtensions.h (right): https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocumentExtensions.h#newcode63 Source/core/svg/SVGDocumentExtensions.h:63: SVGResourcesCache& resourcesCache() const { return *m_resourcesCache; } On 2015/08/19 ...
5 years, 4 months ago (2015-08-19 13:13:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288903003/1
5 years, 4 months ago (2015-08-19 13:13:59 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 13:41:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200826

Powered by Google App Engine
This is Rietveld 408576698