Random clean up of SVGResourcesCache

Random clean up of SVGResourcesCache

 * Fix up some comments.

 * Rename resourcesCacheFromLayoutObject to resourcesCache; let it take
   a Document& instead (to reflect the wider "scope" it has), and make it
   return a SVGResourceCache& since the cache will always be present if
   SVGDocumentExtensions are.

 * Drop redundant qualification.

BUG=521334
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200826

[fs, 2015-08-19 11:43:52]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[davve, 2015-08-19 12:25:53]

davve@opera.com changed reviewers:
+ davve@opera.com

[davve, 2015-08-19 12:25:53]

Non-owner lgtm. Nice and tidy!

[fs, 2015-08-19 13:03:15]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-08-19 13:03:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288903003/1

[f(malita), 2015-08-19 13:04:34]

LGTM!

https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocument...
File Source/core/svg/SVGDocumentExtensions.h (right):

https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocument...
Source/core/svg/SVGDocumentExtensions.h:63: SVGResourcesCache& resourcesCache()
const { return *m_resourcesCache; }
Nit: can we store m_resourcesCache inline (instead of an OwnPtr)? Then this
getter would look more natural.

Also, it would be nice to return a const ref here, but if some clients depend on
non-const then don't worry about it - let's leave fixing world const-correctness
for another day :)

[fs, 2015-08-19 13:06:35]

The CQ bit was unchecked by fs@opera.com

[fs, 2015-08-19 13:13:51]

The CQ bit was checked by fs@opera.com

[fs, 2015-08-19 13:13:58]

https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocument...
File Source/core/svg/SVGDocumentExtensions.h (right):

https://codereview.chromium.org/1288903003/diff/1/Source/core/svg/SVGDocument...
Source/core/svg/SVGDocumentExtensions.h:63: SVGResourcesCache& resourcesCache()
const { return *m_resourcesCache; }
On 2015/08/19 13:04:34, f(malita) wrote:
> Nit: can we store m_resourcesCache inline (instead of an OwnPtr)? Then this
> getter would look more natural.

Yeah, it's not too burdensome - I'll do that in a followup.

> Also, it would be nice to return a const ref here, but if some clients depend
on
> non-const then don't worry about it - let's leave fixing world
const-correctness
> for another day :)

The way this is currently used, I don't think a const ref. would work - the
actual map this keeps is mutated. We could have one const and one non-const, but
I think the former would never be used (we always access it through non-const
SVGDocumentExtentsions AFAICR.)

[commit-bot: I haz the power, 2015-08-19 13:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288903003/1

[commit-bot: I haz the power, 2015-08-19 13:41:06]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200826