Random clean up of SVGResourcesCache

Source/core/svg/SVGDocumentExtensions.h

 /*
  * Copyright (C) 2006 Apple Inc. All rights reserved.
  * Copyright (C) 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 42 matching lines @@
 
     static void serviceOnAnimationFrame(Document&, double monotonicAnimationStartTime);
 
     void startAnimations();
     void pauseAnimations();
     void dispatchSVGLoadEventToOutermostSVGElements();
 
     void reportWarning(const String&);
     void reportError(const String&);
 
-    SVGResourcesCache* resourcesCache() const { return m_resourcesCache.get(); }
+    SVGResourcesCache& resourcesCache() const { return *m_resourcesCache; }

[f(malita), 2015/08/19 13:04:34]

Nit: can we store m_resourcesCache inline (instead of an OwnPtr)? Then this
getter would look more natural.

Also, it would be nice to return a const ref here, but if some clients depend on
non-const then don't worry about it - let's leave fixing world const-correctness
for another day :)

[fs, 2015/08/19 13:13:58]

Yeah, it's not too burdensome - I'll do that in a followup.
The way this is currently used, I don't think a const ref. would work - the
actual map this keeps is mutated. We could have one const and one non-const, but
I think the former would never be used (we always access it through non-const
SVGDocumentExtentsions AFAICR.)

 
     void addSVGRootWithRelativeLengthDescendents(SVGSVGElement*);
     void removeSVGRootWithRelativeLengthDescendents(SVGSVGElement*);
     bool isSVGRootWithRelativeLengthDescendents(SVGSVGElement*) const;
     void invalidateSVGRootsWithRelativeLengthDescendents(SubtreeLayoutScope*);
 
     bool zoomAndPanEnabled() const;
 
     void startPan(const FloatPoint& start);
     void updatePan(const FloatPoint& pos) const;
@@ skipping 34 matching lines @@
     void markPendingResourcesForRemoval(const AtomicString&);
     Element* removeElementFromPendingResourcesForRemoval(const AtomicString&);
 
 private:
     PassOwnPtrWillBeRawPtr<SVGPendingElements> removePendingResourceForRemoval(const AtomicString&);
 };
 
 }
 
 #endif