Refactor ShortcutHelper and merge in BookmarkUtils

chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java
similarity index 91%
rename from chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java
rename to chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java
index 218fa128ed4f62280404d259fbd6e6f67dc051c6..9da66df0c3aa6dc302f929c64ca0debe8bb4e3eb 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenHelperTest.java
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package org.chromium.chrome.browser;
+package org.chromium.chrome.browser.webapps;
 
 import android.content.Context;
 import android.content.Intent;
@@ -13,6 +13,8 @@ import android.text.TextUtils;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.test.util.Feature;
 import org.chromium.base.test.util.UrlUtils;
+import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.ShortcutHelper;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
 import org.chromium.chrome.test.util.browser.TabLoadObserver;
@@ -22,9 +24,9 @@ import org.chromium.content.browser.test.util.CriteriaHelper;
 import java.util.concurrent.Callable;
 
 /**
- * Tests org.chromium.chrome.browser.ShortcutHelper and it's C++ counterpart.
+ * Tests org.chromium.chrome.browser.webapps.AddToHomescreenHelper and it's C++ counterpart.

[gone, 2015/08/13 21:43:15]

nit: it's -> its

[Lalit Maganti, 2015/08/26 13:57:07]

Done in https://codereview.chromium.org/1321463002

  */
-public class ShortcutHelperTest extends ChromeActivityTestCaseBase<ChromeActivity> {
+public class AddToHomescreenHelperTest extends ChromeActivityTestCaseBase<ChromeActivity> {
     private static final String WEBAPP_ACTION_NAME = "WEBAPP_ACTION";
 
     private static final String WEBAPP_TITLE = "Webapp shortcut";
@@ -78,7 +80,7 @@ public class ShortcutHelperTest extends ChromeActivityTestCaseBase<ChromeActivit
     private ChromeActivity mActivity;
     private TestShortcutHelperDelegate mShortcutHelperDelegate;
 
-    public ShortcutHelperTest() {
+    public AddToHomescreenHelperTest() {
         super(ChromeActivity.class);
     }
 
@@ -177,13 +179,13 @@ public class ShortcutHelperTest extends ChromeActivityTestCaseBase<ChromeActivit
         assertTrue(CriteriaHelper.pollForUIThreadCriteria(observer));
 
         // Add the shortcut.
-        Callable<ShortcutHelper> callable = new Callable<ShortcutHelper>() {
+        Callable<AddToHomescreenHelper> callable = new Callable<AddToHomescreenHelper>() {
             @Override
-            public ShortcutHelper call() {
-                final ShortcutHelper helper = new ShortcutHelper(
+            public AddToHomescreenHelper call() {
+                final AddToHomescreenHelper helper = new AddToHomescreenHelper(
                         mActivity.getApplicationContext(), mActivity.getActivityTab());
                 // Calling initialize() isn't strictly required but it is testing this code path.
-                helper.initialize(new ShortcutHelper.ShortcutHelperObserver() {
+                helper.initialize(new AddToHomescreenHelper.AddToHomescreenHelperObserver() {
                     @Override
                     public void onUserTitleAvailable(String t) {
                     }
@@ -196,7 +198,8 @@ public class ShortcutHelperTest extends ChromeActivityTestCaseBase<ChromeActivit
                 return helper;
             }
         };
-        final ShortcutHelper helper = ThreadUtils.runOnUiThreadBlockingNoException(callable);
+        final AddToHomescreenHelper helper =
+                ThreadUtils.runOnUiThreadBlockingNoException(callable);
 
         // Make sure that the shortcut was added.
         assertTrue(CriteriaHelper.pollForUIThreadCriteria(new Criteria() {