Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1288873009: Move hasRenderedNonAnonymousDescendantsWithHeight() to VisibleUnits.cpp from Position.cpp (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move hasRenderedNonAnonymousDescendantsWithHeight() to VisibleUnits.cpp from Position.cpp This patch moves |hasRenderedNonAnonymousDescendantsWithHeight()| form "Position.cpp" to "VisibleUnits.cpp" to reduce |InlineBox| dependency in "Position.cpp" for improving code health, since |hasRender...()| is independent from an implementation of |PositionAlgorithm| template class. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200896

Patch Set 1 : 2015-08-20T18:59:16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M Source/core/editing/Position.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/Position.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-20 11:11:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288873009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288873009/1
5 years, 4 months ago (2015-08-20 11:22:17 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 12:06:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200896

Powered by Google App Engine
This is Rietveld 408576698