Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/editing/Position.h

Issue 1288873009: Move hasRenderedNonAnonymousDescendantsWithHeight() to VisibleUnits.cpp from Position.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-20T18:59:16 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 { 427 {
428 return position; 428 return position;
429 } 429 }
430 430
431 template <> 431 template <>
432 inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg y>(const Position& position) 432 inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg y>(const Position& position)
433 { 433 {
434 return toPositionInComposedTree(position); 434 return toPositionInComposedTree(position);
435 } 435 }
436 436
437 // TODO(yosin) We should move |hasRenderedNonAnonymousDescendantsWithHeight|
438 // to "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp"
439 bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject*);
440
441 // TODO(yosin) We should move |inRenderedText()| to "VisibleUnits.h" for 437 // TODO(yosin) We should move |inRenderedText()| to "VisibleUnits.h" for
442 // reduce dependency of |LayoutObject| in |Position| class. 438 // reduce dependency of |LayoutObject| in |Position| class.
443 CORE_EXPORT bool inRenderedText(const Position&); 439 CORE_EXPORT bool inRenderedText(const Position&);
444 CORE_EXPORT bool inRenderedText(const PositionInComposedTree&); 440 CORE_EXPORT bool inRenderedText(const PositionInComposedTree&);
445 441
446 CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current); 442 CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current);
447 CORE_EXPORT int uncheckedNextOffset(const Node*, int current); 443 CORE_EXPORT int uncheckedNextOffset(const Node*, int current);
448 444
449 } // namespace blink 445 } // namespace blink
450 446
451 #ifndef NDEBUG 447 #ifndef NDEBUG
452 // Outside the WebCore namespace for ease of invocation from gdb. 448 // Outside the WebCore namespace for ease of invocation from gdb.
453 void showTree(const blink::Position&); 449 void showTree(const blink::Position&);
454 void showTree(const blink::Position*); 450 void showTree(const blink::Position*);
455 #endif 451 #endif
456 452
457 #endif // Position_h 453 #endif // Position_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698