Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288623004: Devtools: Remove continuous repainting feature (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Remove continuous repainting feature BUG=523040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200719

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -176 lines) Patch
M Source/devtools/front_end/main/RenderingOptions.js View 1 3 chunks +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/DevToolsEmulator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/InspectorRenderingAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorRenderingAgent.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/web/WebViewImpl.h View 3 chunks +1 line, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 5 chunks +2 lines, -31 lines 0 comments Download
D Source/web/painting/ContinuousPainter.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/web/painting/ContinuousPainter.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
samli
5 years, 4 months ago (2015-08-18 04:41:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288623004/1
5 years, 4 months ago (2015-08-18 04:41:50 UTC) #4
samli
I'm not meant to touch Inspector-x.x.json files right?
5 years, 4 months ago (2015-08-18 04:43:08 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/86372)
5 years, 4 months ago (2015-08-18 04:43:54 UTC) #7
pfeldman
lgtm
5 years, 4 months ago (2015-08-18 05:10:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288623004/20001
5 years, 4 months ago (2015-08-18 05:15:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/57737) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-18 05:17:44 UTC) #12
pfeldman
btw, is there a cc/chrome patch to go with this one?
5 years, 4 months ago (2015-08-18 05:21:44 UTC) #13
samli
On 2015/08/18 at 05:21:44, pfeldman wrote: > btw, is there a cc/chrome patch to go ...
5 years, 4 months ago (2015-08-18 05:24:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288623004/20001
5 years, 4 months ago (2015-08-18 07:39:08 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 10:27:21 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200719

Powered by Google App Engine
This is Rietveld 408576698