net/url_request/url_request_context_builder.h - Issue 1288383002: Use common code to set HttpNetworkSession::Param pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_context_builder.h

Issue 1288383002: Use common code to set HttpNetworkSession::Param pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove check, http_cache_enabled_ || !channel_id_service. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_io_data.cc ('K') | « chrome/browser/profiles/profile_io_data.cc ('k') | net/url_request/url_request_context_builder.cc » ('j') | net/url_request/url_request_context_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_context_builder.h

diff --git a/net/url_request/url_request_context_builder.h b/net/url_request/url_request_context_builder.h

index 6e614dc6f95d2ed9c6a2cd2d309c1760401d081c..ad3d2cff5097edac2c77a30941a3f702fd289348 100644

--- a/net/url_request/url_request_context_builder.h

+++ b/net/url_request/url_request_context_builder.h

@@ -26,6 +26,7 @@

#include "net/base/net_export.h"

#include "net/base/network_delegate.h"

#include "net/dns/host_resolver.h"

+#include "net/http/http_network_session.h"

#include "net/proxy/proxy_config_service.h"

#include "net/proxy/proxy_service.h"

#include "net/quic/quic_protocol.h"

@@ -86,6 +87,10 @@ class NET_EXPORT URLRequestContextBuilder {

QuicTagVector quic_connection_options;

};

+ static void SetHttpNetworkSessionComponents(

+ HttpNetworkSession::Params* params,

+ URLRequestContext* context);

mmenke 2015/08/17 20:13:04 nit: Per google style guide, inputs should go bef

mmenke 2015/08/17 20:13:04 This should go after the constructor and destructo

wjmaclean 2015/08/18 14:17:23 Done.

wjmaclean 2015/08/18 14:17:23 Done. Sorry about that ... I thought static functi

URLRequestContextBuilder();

~URLRequestContextBuilder();