Use common code to set HttpNetworkSession::Param pointers.

net/url_request/url_request_context_builder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class is useful for building a simple URLRequestContext. Most creators
 // of new URLRequestContexts should use this helper class to construct it. Call
 // any configuration params, and when done, invoke Build() to construct the
 // URLRequestContext. This URLRequestContext will own all its own storage.
 //
 // URLRequestContextBuilder and its associated params classes are initially
 // populated with "sane" default values. Read through the comments to figure out
 // what these are.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_
 #define NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "build/build_config.h"
 #include "net/base/net_export.h"
 #include "net/base/network_delegate.h"
 #include "net/dns/host_resolver.h"
+#include "net/http/http_network_session.h"
 #include "net/proxy/proxy_config_service.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/quic_protocol.h"
 #include "net/socket/next_proto.h"
 
 namespace base {
 class SingleThreadTaskRunner;
 }
 
 namespace net {
@@ skipping 40 matching lines @@
     uint16 testing_fixed_http_port;
     uint16 testing_fixed_https_port;
     NextProtoVector next_protos;
     std::string trusted_spdy_proxy;
     bool use_alternate_protocols;
     bool enable_quic;
     bool enable_insecure_quic;
     QuicTagVector quic_connection_options;
   };
 
+  static void SetHttpNetworkSessionComponents(
+      HttpNetworkSession::Params* params,
+      URLRequestContext* context);

[mmenke, 2015/08/17 20:13:04]

nit:  Per google style guide, inputs should go before outputs, and the context
is basically an input.

I believe you can also make the context a const reference, too.

[mmenke, 2015/08/17 20:13:04]

This should go after the constructor and destructor.

[wjmaclean, 2015/08/18 14:17:23]

Done.

[wjmaclean, 2015/08/18 14:17:23]

Done. Sorry about that ... I thought static functions went ahead, but that's
just faulty memory on my part :-)

+
   URLRequestContextBuilder();
   ~URLRequestContextBuilder();
 
   // These functions are mutually exclusive.  The ProxyConfigService, if
   // set, will be used to construct a ProxyService.
   void set_proxy_config_service(ProxyConfigService* proxy_config_service) {
     proxy_config_service_.reset(proxy_config_service);
   }
   void set_proxy_service(ProxyService* proxy_service) {
     proxy_service_.reset(proxy_service);
@@ skipping 166 matching lines @@
   std::vector<SchemeFactory> extra_http_auth_handlers_;
   ScopedVector<URLRequestInterceptor> url_request_interceptors_;
   scoped_ptr<HttpServerProperties> http_server_properties_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextBuilder);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_