Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1288313003: [strong] Fix weird work-around for magic truncating int conversions. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev, conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Fix weird work-around for magic truncating int conversions. Bitwise operations in strong mode must not magically truncate oddballs to integers, but must throw in this case. This basically disable the whole truncate-to-int32 optimization for strong mode bitwise operations, but is still better than having to do oddball checks for every strong bitwise operation (which esp. includes the BinaryOpIC stubs for that). R=rossberg@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M src/hydrogen.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-13 09:39:05 UTC) #1
Benedikt Meurer
Hey Andreas, This is the fix we worked on offline. Please take a look. Thanks, ...
5 years, 4 months ago (2015-08-13 09:39:30 UTC) #2
rossberg
lgtm
5 years, 4 months ago (2015-08-13 09:43:09 UTC) #3
Benedikt Meurer
Conrad: FYI
5 years, 4 months ago (2015-08-13 09:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288313003/1
5 years, 4 months ago (2015-08-13 09:43:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 09:51:37 UTC) #8
Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8516)

Powered by Google App Engine
This is Rietveld 408576698