Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/hydrogen-instructions.h

Issue 1288313003: [strong] Fix weird work-around for magic truncating int conversions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 4137 matching lines...) Expand 10 before | Expand all | Expand 10 after
4148 bool IsPurelyInformativeDefinition() override { return true; } 4148 bool IsPurelyInformativeDefinition() override { return true; }
4149 }; 4149 };
4150 4150
4151 4151
4152 class HBitwiseBinaryOperation : public HBinaryOperation { 4152 class HBitwiseBinaryOperation : public HBinaryOperation {
4153 public: 4153 public:
4154 HBitwiseBinaryOperation(HValue* context, HValue* left, HValue* right, 4154 HBitwiseBinaryOperation(HValue* context, HValue* left, HValue* right,
4155 Strength strength, HType type = HType::TaggedNumber()) 4155 Strength strength, HType type = HType::TaggedNumber())
4156 : HBinaryOperation(context, left, right, strength, type) { 4156 : HBinaryOperation(context, left, right, strength, type) {
4157 SetFlag(kFlexibleRepresentation); 4157 SetFlag(kFlexibleRepresentation);
4158 SetFlag(kTruncatingToInt32); 4158 if (!is_strong(strength)) {
4159 if (!is_strong(strength)) SetFlag(kAllowUndefinedAsNaN); 4159 SetFlag(kTruncatingToInt32);
4160 SetFlag(kAllowUndefinedAsNaN);
4161 }
4160 SetAllSideEffects(); 4162 SetAllSideEffects();
4161 } 4163 }
4162 4164
4163 void RepresentationChanged(Representation to) override { 4165 void RepresentationChanged(Representation to) override {
4164 if (to.IsTagged() && 4166 if (to.IsTagged() &&
4165 (left()->ToNumberCanBeObserved() || right()->ToNumberCanBeObserved())) { 4167 (left()->ToNumberCanBeObserved() || right()->ToNumberCanBeObserved())) {
4166 SetAllSideEffects(); 4168 SetAllSideEffects();
4167 ClearFlag(kUseGVN); 4169 ClearFlag(kUseGVN);
4168 } else { 4170 } else {
4169 ClearAllSideEffects(); 4171 ClearAllSideEffects();
(...skipping 3891 matching lines...) Expand 10 before | Expand all | Expand 10 after
8061 }; 8063 };
8062 8064
8063 8065
8064 8066
8065 #undef DECLARE_INSTRUCTION 8067 #undef DECLARE_INSTRUCTION
8066 #undef DECLARE_CONCRETE_INSTRUCTION 8068 #undef DECLARE_CONCRETE_INSTRUCTION
8067 8069
8068 } } // namespace v8::internal 8070 } } // namespace v8::internal
8069 8071
8070 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 8072 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698