Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: ui/base/l10n/l10n_util_android.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/l10n/l10n_util_android.cc
diff --git a/ui/base/l10n/l10n_util_android.cc b/ui/base/l10n/l10n_util_android.cc
index 63e0f8247fa0dd51016b54c1b8ea9980da01b159..55cd4b2f273e9ad574aa6705c66e9bb8c566274d 100644
--- a/ui/base/l10n/l10n_util_android.cc
+++ b/ui/base/l10n/l10n_util_android.cc
@@ -92,14 +92,16 @@ base::string16 GetDisplayNameForLocale(const std::string& locale,
return ConvertJavaStringToUTF16(java_result);
}
-jstring GetDurationString(JNIEnv* env, jclass clazz, jlong timeInMillis) {
+ScopedJavaLocalRef<jstring> GetDurationString(JNIEnv* env,
+ jclass clazz,
+ jlong timeInMillis) {
ScopedJavaLocalRef<jstring> jtime_remaining =
base::android::ConvertUTF16ToJavaString(
env,
ui::TimeFormat::Simple(
ui::TimeFormat::FORMAT_REMAINING, ui::TimeFormat::LENGTH_SHORT,
base::TimeDelta::FromMilliseconds(timeInMillis)));
- return jtime_remaining.Release();
+ return jtime_remaining;
}
bool RegisterLocalizationUtil(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698