Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: sync/android/model_type_helper.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/android/model_type_helper.cc
diff --git a/sync/android/model_type_helper.cc b/sync/android/model_type_helper.cc
index 6d30eaa6d03f171807959970aa628d65f22876b9..37650cbdf39d102912717103656e357846c34f4c 100644
--- a/sync/android/model_type_helper.cc
+++ b/sync/android/model_type_helper.cc
@@ -11,16 +11,14 @@
namespace syncer {
-static jstring ModelTypeToNotificationType(JNIEnv* env,
- jclass clazz,
- jint model_type_int) {
+static ScopedJavaLocalRef<jstring>
+ModelTypeToNotificationType(JNIEnv* env, jclass clazz, jint model_type_int) {
std::string model_type_string;
ModelType model_type = static_cast<ModelType>(model_type_int);
if (!RealModelTypeToNotificationType(model_type, &model_type_string)) {
NOTREACHED() << "No string representation of model type " << model_type;
}
- return base::android::ConvertUTF8ToJavaString(env, model_type_string)
- .Release();
+ return base::android::ConvertUTF8ToJavaString(env, model_type_string);
}
bool RegisterModelTypeHelperJni(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698