Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: sync/android/model_type_helper.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/android/model_type_helper.h" 5 #include "sync/android/model_type_helper.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "jni/ModelTypeHelper_jni.h" 9 #include "jni/ModelTypeHelper_jni.h"
10 #include "sync/internal_api/public/base/model_type.h" 10 #include "sync/internal_api/public/base/model_type.h"
11 11
12 namespace syncer { 12 namespace syncer {
13 13
14 static jstring ModelTypeToNotificationType(JNIEnv* env, 14 static ScopedJavaLocalRef<jstring>
15 jclass clazz, 15 ModelTypeToNotificationType(JNIEnv* env, jclass clazz, jint model_type_int) {
16 jint model_type_int) {
17 std::string model_type_string; 16 std::string model_type_string;
18 ModelType model_type = static_cast<ModelType>(model_type_int); 17 ModelType model_type = static_cast<ModelType>(model_type_int);
19 if (!RealModelTypeToNotificationType(model_type, &model_type_string)) { 18 if (!RealModelTypeToNotificationType(model_type, &model_type_string)) {
20 NOTREACHED() << "No string representation of model type " << model_type; 19 NOTREACHED() << "No string representation of model type " << model_type;
21 } 20 }
22 return base::android::ConvertUTF8ToJavaString(env, model_type_string) 21 return base::android::ConvertUTF8ToJavaString(env, model_type_string);
23 .Release();
24 } 22 }
25 23
26 bool RegisterModelTypeHelperJni(JNIEnv* env) { 24 bool RegisterModelTypeHelperJni(JNIEnv* env) {
27 return RegisterNativesImpl(env); 25 return RegisterNativesImpl(env);
28 } 26 }
29 27
30 } // namespace syncer 28 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698