Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: components/cronet/android/test/native_test_server.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/native_test_server.cc
diff --git a/components/cronet/android/test/native_test_server.cc b/components/cronet/android/test/native_test_server.cc
index 908ddb07e664414ad607f4425a907b54cad03c69..756442b618bca4adae9b7d1e921127ffdb24f43d 100644
--- a/components/cronet/android/test/native_test_server.cc
+++ b/components/cronet/android/test/native_test_server.cc
@@ -254,59 +254,63 @@ void ShutdownNativeTestServer(JNIEnv* env, jclass jcaller) {
g_test_server = NULL;
}
-jstring GetEchoBodyURL(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetEchoBodyURL(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
GURL url = g_test_server->GetURL(kEchoBodyPath);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetEchoHeaderURL(JNIEnv* env, jclass jcaller, jstring jheader) {
+ScopedJavaLocalRef<jstring> GetEchoHeaderURL(JNIEnv* env,
+ jclass jcaller,
+ jstring jheader) {
DCHECK(g_test_server);
GURL url = g_test_server->GetURL(kEchoHeaderPath);
GURL::Replacements replacements;
std::string header = base::android::ConvertJavaStringToUTF8(env, jheader);
replacements.SetQueryStr(header.c_str());
url = url.ReplaceComponents(replacements);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetEchoAllHeadersURL(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetEchoAllHeadersURL(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
GURL url = g_test_server->GetURL(kEchoAllHeadersPath);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetEchoMethodURL(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetEchoMethodURL(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
GURL url = g_test_server->GetURL(kEchoMethodPath);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetRedirectToEchoBody(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetRedirectToEchoBody(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
GURL url = g_test_server->GetURL(kRedirectToEchoBodyPath);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetFileURL(JNIEnv* env, jclass jcaller, jstring jfile_path) {
+ScopedJavaLocalRef<jstring> GetFileURL(JNIEnv* env,
+ jclass jcaller,
+ jstring jfile_path) {
DCHECK(g_test_server);
std::string file = base::android::ConvertJavaStringToUTF8(env, jfile_path);
GURL url = g_test_server->GetURL(file);
- return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url.spec());
}
-jstring GetSdchURL(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetSdchURL(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
std::string url(base::StringPrintf("http://%s:%d", kFakeSdchDomain,
g_test_server->port()));
- return base::android::ConvertUTF8ToJavaString(env, url).Release();
+ return base::android::ConvertUTF8ToJavaString(env, url);
}
-jstring GetHostPort(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetHostPort(JNIEnv* env, jclass jcaller) {
DCHECK(g_test_server);
std::string host_port =
net::HostPortPair::FromURL(g_test_server->base_url()).ToString();
- return base::android::ConvertUTF8ToJavaString(env, host_port).Release();
+ return base::android::ConvertUTF8ToJavaString(env, host_port);
}
jboolean IsDataReductionProxySupported(JNIEnv* env, jclass jcaller) {

Powered by Google App Engine
This is Rietveld 408576698