Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: components/cronet/android/test/native_test_server.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "native_test_server.h" 5 #include "native_test_server.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 } 247 }
248 } 248 }
249 249
250 void ShutdownNativeTestServer(JNIEnv* env, jclass jcaller) { 250 void ShutdownNativeTestServer(JNIEnv* env, jclass jcaller) {
251 if (!g_test_server) 251 if (!g_test_server)
252 return; 252 return;
253 delete g_test_server; 253 delete g_test_server;
254 g_test_server = NULL; 254 g_test_server = NULL;
255 } 255 }
256 256
257 jstring GetEchoBodyURL(JNIEnv* env, jclass jcaller) { 257 ScopedJavaLocalRef<jstring> GetEchoBodyURL(JNIEnv* env, jclass jcaller) {
258 DCHECK(g_test_server); 258 DCHECK(g_test_server);
259 GURL url = g_test_server->GetURL(kEchoBodyPath); 259 GURL url = g_test_server->GetURL(kEchoBodyPath);
260 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 260 return base::android::ConvertUTF8ToJavaString(env, url.spec());
261 } 261 }
262 262
263 jstring GetEchoHeaderURL(JNIEnv* env, jclass jcaller, jstring jheader) { 263 ScopedJavaLocalRef<jstring> GetEchoHeaderURL(JNIEnv* env,
264 jclass jcaller,
265 jstring jheader) {
264 DCHECK(g_test_server); 266 DCHECK(g_test_server);
265 GURL url = g_test_server->GetURL(kEchoHeaderPath); 267 GURL url = g_test_server->GetURL(kEchoHeaderPath);
266 GURL::Replacements replacements; 268 GURL::Replacements replacements;
267 std::string header = base::android::ConvertJavaStringToUTF8(env, jheader); 269 std::string header = base::android::ConvertJavaStringToUTF8(env, jheader);
268 replacements.SetQueryStr(header.c_str()); 270 replacements.SetQueryStr(header.c_str());
269 url = url.ReplaceComponents(replacements); 271 url = url.ReplaceComponents(replacements);
270 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 272 return base::android::ConvertUTF8ToJavaString(env, url.spec());
271 } 273 }
272 274
273 jstring GetEchoAllHeadersURL(JNIEnv* env, jclass jcaller) { 275 ScopedJavaLocalRef<jstring> GetEchoAllHeadersURL(JNIEnv* env, jclass jcaller) {
274 DCHECK(g_test_server); 276 DCHECK(g_test_server);
275 GURL url = g_test_server->GetURL(kEchoAllHeadersPath); 277 GURL url = g_test_server->GetURL(kEchoAllHeadersPath);
276 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 278 return base::android::ConvertUTF8ToJavaString(env, url.spec());
277 } 279 }
278 280
279 jstring GetEchoMethodURL(JNIEnv* env, jclass jcaller) { 281 ScopedJavaLocalRef<jstring> GetEchoMethodURL(JNIEnv* env, jclass jcaller) {
280 DCHECK(g_test_server); 282 DCHECK(g_test_server);
281 GURL url = g_test_server->GetURL(kEchoMethodPath); 283 GURL url = g_test_server->GetURL(kEchoMethodPath);
282 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 284 return base::android::ConvertUTF8ToJavaString(env, url.spec());
283 } 285 }
284 286
285 jstring GetRedirectToEchoBody(JNIEnv* env, jclass jcaller) { 287 ScopedJavaLocalRef<jstring> GetRedirectToEchoBody(JNIEnv* env, jclass jcaller) {
286 DCHECK(g_test_server); 288 DCHECK(g_test_server);
287 GURL url = g_test_server->GetURL(kRedirectToEchoBodyPath); 289 GURL url = g_test_server->GetURL(kRedirectToEchoBodyPath);
288 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 290 return base::android::ConvertUTF8ToJavaString(env, url.spec());
289 } 291 }
290 292
291 jstring GetFileURL(JNIEnv* env, jclass jcaller, jstring jfile_path) { 293 ScopedJavaLocalRef<jstring> GetFileURL(JNIEnv* env,
294 jclass jcaller,
295 jstring jfile_path) {
292 DCHECK(g_test_server); 296 DCHECK(g_test_server);
293 std::string file = base::android::ConvertJavaStringToUTF8(env, jfile_path); 297 std::string file = base::android::ConvertJavaStringToUTF8(env, jfile_path);
294 GURL url = g_test_server->GetURL(file); 298 GURL url = g_test_server->GetURL(file);
295 return base::android::ConvertUTF8ToJavaString(env, url.spec()).Release(); 299 return base::android::ConvertUTF8ToJavaString(env, url.spec());
296 } 300 }
297 301
298 jstring GetSdchURL(JNIEnv* env, jclass jcaller) { 302 ScopedJavaLocalRef<jstring> GetSdchURL(JNIEnv* env, jclass jcaller) {
299 DCHECK(g_test_server); 303 DCHECK(g_test_server);
300 std::string url(base::StringPrintf("http://%s:%d", kFakeSdchDomain, 304 std::string url(base::StringPrintf("http://%s:%d", kFakeSdchDomain,
301 g_test_server->port())); 305 g_test_server->port()));
302 return base::android::ConvertUTF8ToJavaString(env, url).Release(); 306 return base::android::ConvertUTF8ToJavaString(env, url);
303 } 307 }
304 308
305 jstring GetHostPort(JNIEnv* env, jclass jcaller) { 309 ScopedJavaLocalRef<jstring> GetHostPort(JNIEnv* env, jclass jcaller) {
306 DCHECK(g_test_server); 310 DCHECK(g_test_server);
307 std::string host_port = 311 std::string host_port =
308 net::HostPortPair::FromURL(g_test_server->base_url()).ToString(); 312 net::HostPortPair::FromURL(g_test_server->base_url()).ToString();
309 return base::android::ConvertUTF8ToJavaString(env, host_port).Release(); 313 return base::android::ConvertUTF8ToJavaString(env, host_port);
310 } 314 }
311 315
312 jboolean IsDataReductionProxySupported(JNIEnv* env, jclass jcaller) { 316 jboolean IsDataReductionProxySupported(JNIEnv* env, jclass jcaller) {
313 #if defined(DATA_REDUCTION_PROXY_SUPPORT) 317 #if defined(DATA_REDUCTION_PROXY_SUPPORT)
314 return JNI_TRUE; 318 return JNI_TRUE;
315 #else 319 #else
316 return JNI_FALSE; 320 return JNI_FALSE;
317 #endif 321 #endif
318 } 322 }
319 323
320 bool RegisterNativeTestServer(JNIEnv* env) { 324 bool RegisterNativeTestServer(JNIEnv* env) {
321 return RegisterNativesImpl(env); 325 return RegisterNativesImpl(env);
322 } 326 }
323 327
324 } // namespace cronet 328 } // namespace cronet
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698