Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/ui/android/omnibox/omnibox_view_util.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/omnibox/omnibox_view_util.cc
diff --git a/chrome/browser/ui/android/omnibox/omnibox_view_util.cc b/chrome/browser/ui/android/omnibox/omnibox_view_util.cc
index d389fb53f337166dbd21bf63e22e384c57b1f90a..5a19a5b12cafddaab5e3caa1cb562c60f6894fd9 100644
--- a/chrome/browser/ui/android/omnibox/omnibox_view_util.cc
+++ b/chrome/browser/ui/android/omnibox/omnibox_view_util.cc
@@ -9,11 +9,13 @@
#include "jni/OmniboxViewUtil_jni.h"
// static
-jstring SanitizeTextForPaste(JNIEnv* env, jclass clazz, jstring jtext) {
+ScopedJavaLocalRef<jstring> SanitizeTextForPaste(JNIEnv* env,
+ jclass clazz,
+ jstring jtext) {
base::string16 pasted_text(
base::android::ConvertJavaStringToUTF16(env, jtext));
pasted_text = OmniboxView::SanitizeTextForPaste(pasted_text);
- return base::android::ConvertUTF16ToJavaString(env, pasted_text).Release();
+ return base::android::ConvertUTF16ToJavaString(env, pasted_text);
}
// static

Powered by Google App Engine
This is Rietveld 408576698