Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc
diff --git a/chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc b/chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc
index b70f89dde0f303322850d03e792c078ea5b11902..73cb692ee3742a4247dd4784b0bd565224942c27 100644
--- a/chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc
+++ b/chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc
@@ -12,10 +12,10 @@
#include "jni/OmniboxUrlEmphasizer_jni.h"
// static
-jintArray ParseForEmphasizeComponents(JNIEnv* env,
- jclass clazz,
- jobject jprofile,
- jstring jtext) {
+ScopedJavaLocalRef<jintArray> ParseForEmphasizeComponents(JNIEnv* env,
+ jclass clazz,
+ jobject jprofile,
+ jstring jtext) {
Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
DCHECK(profile);
@@ -26,7 +26,7 @@ jintArray ParseForEmphasizeComponents(JNIEnv* env,
text, ChromeAutocompleteSchemeClassifier(profile), &scheme, &host);
int emphasize_values[] = {scheme.begin, scheme.len, host.begin, host.len};
- return base::android::ToJavaIntArray(env, emphasize_values, 4).Release();
+ return base::android::ToJavaIntArray(env, emphasize_values, 4);
}
// static

Powered by Google App Engine
This is Rietveld 408576698